-
Notifications
You must be signed in to change notification settings - Fork 619
refactor: simplify API fetch error handling in aa-chains route #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify API fetch error handling in aa-chains route #5119
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @joaquim-verges and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5119 +/- ##
==========================================
+ Coverage 45.29% 45.33% +0.03%
==========================================
Files 1059 1060 +1
Lines 54754 54773 +19
Branches 3959 3954 -5
==========================================
+ Hits 24803 24832 +29
+ Misses 29260 29250 -10
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
c5035a7 to
8babad2
Compare
8babad2 to
ffc839a
Compare
ffc839a to
114d6a3
Compare
114d6a3 to
7cceaa1
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR refactors the
getChainsfunction inAAChainList.tsxto fetch chain data from a new API endpoint, replacing the previous implementation that relied on a local base URL. It improves error handling and modifies the logic for filtering and returning relevant chains.Detailed summary
getBaseUrland related code.ApiResponseTypefor the API response structure.getChainsto fetch data fromhttps://api.thirdweb.com/v1/chains/servicesandhttps://api.thirdweb.com/v1/chains.