-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] minor fix for test #5122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] minor fix for test #5122
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5122 +/- ##
==========================================
+ Coverage 45.26% 45.28% +0.01%
==========================================
Files 1061 1060 -1
Lines 54869 54841 -28
Branches 3955 3957 +2
==========================================
- Hits 24837 24835 -2
+ Misses 29341 29315 -26
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
935d172 to
c991b28
Compare
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR refactors the test for the `mintToBatch` function, changing its execution context and updating the minting logic to utilize `mintAdditionalSupplyToBatch`. It also modifies the structure of the NFT data being tested.
### Detailed summary
- Changed `describe` to use `describe.runIf(process.env.TW_SECRET_KEY)`.
- Updated minting function from `mintToBatch` to `mintAdditionalSupplyToBatch`.
- Adjusted parameters for minting NFTs.
- Modified the expected NFT details in the final assertion.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
c991b28 to
5351d4e
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR refactors the test for minting additional supply to an ERC1155 batch, updating the test structure and changing the transaction method used to mint tokens.
Detailed summary
describe.runIf(process.env.TW_SECRET_KEY).mintToBatchtomintAdditionalSupplyToBatch.