-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Optimize mintAdditionalSupplyToBatch #5125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d522343 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6ad7218 to
ffd9b8b
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5125 +/- ##
==========================================
+ Coverage 45.34% 45.38% +0.03%
==========================================
Files 1064 1064
Lines 55030 55054 +24
Branches 3965 3965
==========================================
+ Hits 24954 24986 +32
+ Misses 29384 29376 -8
Partials 692 692
*This pull request uses carry forward flags. Click here to find out more.
|
ffd9b8b to
885ac65
Compare
885ac65 to
a1907ec
Compare
c991b28 to
5351d4e
Compare
a1907ec to
185d9ef
Compare
Merge activity
|
185d9ef to
658c4f3
Compare
658c4f3 to
29196d7
Compare
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on optimizing the `mintAdditionalSupplyToBatch` extension by introducing a new function to batch minting requests that share the same recipient and token ID, reducing the number of transactions required.
### Detailed summary
- Added `WithOverrides` to `MintAdditionalSupplyToBatchParams`.
- Implemented `optimizeMintBatchContent` function to consolidate minting requests.
- Updated `mintAdditionalSupplyToBatch` to use optimized NFT data.
- Added a test for `optimizeMintBatchContent` to verify its functionality.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
29196d7 to
d522343
Compare

Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on optimizing the
mintAdditionalSupplyToBatchextension in thethirdweblibrary by introducing a new function to batch minting requests that share the sametoaddress andtokenId, improving efficiency.Detailed summary
WithOverridestype toMintAdditionalSupplyToBatchParams.optimizeMintBatchContentfunction to batch minting requests.mintAdditionalSupplyToBatchto utilize the new optimization.optimizeMintBatchContent.