[Dashboard] Remove Drawer from LazyMint form #5264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
Author
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5264 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1067 1067
Lines 55449 55449
Branches 3989 3989
=======================================
Hits 25157 25157
Misses 29601 29601
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/remove-drawer-mintTo-form
branch
from
2f01ab1 to
cf3c54b
Compare
kien-ngo
force-pushed
the
kien/remove-drawer-lazyMint-form
branch
from
7bc7ef5 to
9e70db2
Compare
kien-ngo
force-pushed
the
kien/remove-drawer-mintTo-form
branch
from
cf3c54b to
aa57271
Compare
kien-ngo
force-pushed
the
kien/remove-drawer-lazyMint-form
branch
from
9e70db2 to
aca761b
Compare
jnsdls
approved these changes
Nov 2, 2024
kien-ngo
force-pushed
the
kien/remove-drawer-mintTo-form
branch
from
aa57271 to
43d2a7f
Compare
kien-ngo
force-pushed
the
kien/remove-drawer-lazyMint-form
branch
from
aca761b to
c488825
Compare
graphite-app
bot
added
the
merge-queue
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on refactoring the `NFTLazyMintButton` and `LazyMintNftForm` components to replace the `Drawer` UI component with a `Sheet` component for a better user interface experience during the NFT minting process.
### Detailed summary
- Replaced `Drawer` with `Sheet` in `NFTLazyMintButton`.
- Added `SheetTrigger` and `SheetContent` to manage the button and form display.
- Introduced `setOpen` state in `NFTLazyMintButton` to control the `Sheet`.
- Modified `LazyMintNftForm` to accept `setOpen` prop for closing the `Sheet`.
- Updated success and error handling with `toast` notifications instead of modal context.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
kien/remove-drawer-mintTo-form
branch
from
43d2a7f to
9d1f75d
Compare
gregfromstl
force-pushed
the
kien/remove-drawer-lazyMint-form
branch
from
c488825 to
5484075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on refactoring the
NFTLazyMintButtonandLazyMintNftFormcomponents to replace theDrawerUI with aSheetUI, improving the user interface for lazy minting NFTs.Detailed summary
DrawerwithSheetinNFTLazyMintButton.useDisclosuretouseState.LazyMintNftFormto acceptsetOpenprop for controlling theSheet.useModalContextand related modal handling.toastnotifications for success and error handling.LazyMintNftForm.