Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 1, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR refactors the CreateListingButton and CreateListingsForm components to replace the Drawer UI component with a Sheet component for better user experience. It also enhances form handling and error management.

Detailed summary

  • Replaced Drawer with Sheet in CreateListingButton.
  • Updated state management for opening and closing the form.
  • Modified CreateListingsForm to accept actionText and setOpen props.
  • Improved error handling with toast.promise for async operations.
  • Added a fixed button for form submission and cancellation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 2:13am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 2, 2024 2:13am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 2, 2024 2:13am
wallet-ui ⬜️ Skipped (Inspect) Nov 2, 2024 2:13am

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: c3f2404

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 22:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 22:20 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 1, 2024
Copy link
Contributor Author

kien-ngo commented Nov 1, 2024

@kien-ngo kien-ngo changed the title [Dashboard] Remove Drawer & cleanup marketplace listnig form [Dashboard] Remove Drawer & cleanup marketplace listing form Nov 1, 2024
@kien-ngo kien-ngo marked this pull request as ready for review November 1, 2024 22:20
@codecov
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (5484075) to head (c3f2404).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5265   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1067     1067           
  Lines       55449    55449           
  Branches     3989     3989           
=======================================
  Hits        25157    25157           
  Misses      29601    29601           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5484075
packages 40.41% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43 KB (0%) 861 ms (0%) 542 ms (-27.29% 🔽) 1.5 s
thirdweb (cjs) 102.88 KB (0%) 2.1 s (0%) 2.2 s (+74.62% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 41 ms (-47.66% 🔽) 137 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 179 ms (+560.69% 🔺) 189 ms
thirdweb/react (minimal + tree-shaking) 17 KB (0%) 341 ms (0%) 435 ms (+259.72% 🔺) 775 ms

@kien-ngo kien-ngo force-pushed the kien/remove-drawer-lazyMint-form branch from 7bc7ef5 to 9e70db2 Compare November 1, 2024 23:34
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-marketplace-listing-form branch from ea33c47 to 1e517b9 Compare November 1, 2024 23:34
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 23:35 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 23:35 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 23:35 Inactive
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-lazyMint-form branch from 9e70db2 to aca761b Compare November 1, 2024 23:36
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-marketplace-listing-form branch from 1e517b9 to 6ce4e43 Compare November 1, 2024 23:36
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 23:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 23:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 23:36 Inactive
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-lazyMint-form branch from aca761b to c488825 Compare November 2, 2024 01:09
@kien-ngo kien-ngo force-pushed the kien/remove-drawer-marketplace-listing-form branch from 6ce4e43 to f2a7bad Compare November 2, 2024 01:09
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 01:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 01:09 Inactive
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 2, 2024
Copy link
Contributor

gregfromstl commented Nov 2, 2024

Merge activity

  • Nov 1, 9:14 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 1, 9:29 PM EDT: A user added this pull request to the Graphite merge queue.
  • Nov 1, 10:15 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `CreateListingButton` and `CreateListingsForm` components to replace the `Drawer` component with a `Sheet` component for better user interface interaction in the marketplace.

### Detailed summary
- Replaced `Drawer` with `Sheet` in `CreateListingButton`.
- Updated state management for opening/closing the form.
- Modified button and form structure to align with `Sheet` component.
- Added `actionText` and `setOpen` props to `CreateListingsForm`.
- Introduced toast notifications for transaction promises in `CreateListingsForm`.
- Implemented a fixed button section for form submission and cancellation.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@gregfromstl gregfromstl force-pushed the kien/remove-drawer-lazyMint-form branch from c488825 to 5484075 Compare November 2, 2024 01:56
@gregfromstl gregfromstl force-pushed the kien/remove-drawer-marketplace-listing-form branch from f2a7bad to c3f2404 Compare November 2, 2024 01:56
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 01:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 01:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 01:56 Inactive
Base automatically changed from kien/remove-drawer-lazyMint-form to main November 2, 2024 02:14
@graphite-app graphite-app bot merged commit c3f2404 into main Nov 2, 2024
29 of 31 checks passed
@graphite-app graphite-app bot deleted the kien/remove-drawer-marketplace-listing-form branch November 2, 2024 02:15
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 2, 2024 02:15 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 November 2, 2024 02:15 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 2, 2024 02:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants