[Dashboard] Remove Drawer from ERC1155 udpate-metadata form #5269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
This was referenced Nov 2, 2024
Contributor
Author
This was referenced Nov 2, 2024
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...rc/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/tokens/components/airdrop-button.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5269 +/- ##
=======================================
Coverage 45.36% 45.36%
=======================================
Files 1067 1067
Lines 55449 55449
Branches 3989 3989
=======================================
Hits 25157 25157
Misses 29601 29601
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
kien-ngo
force-pushed
the
kien/remove-drawer-erc1155-update-metadata
branch
from
2c442aa to
bf0aa46
Compare
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Nov 2, 2024
kien-ngo
force-pushed
the
kien/remove-drawer-marketplace-listing-form
branch
from
6ce4e43 to
f2a7bad
Compare
kien-ngo
force-pushed
the
kien/remove-drawer-erc1155-update-metadata
branch
from
bf0aa46 to
ca1f2d2
Compare
jnsdls
approved these changes
Nov 2, 2024
gregfromstl
added
the
merge-queue
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR primarily focuses on updating the user interface components related to NFT actions, enhancing text alignment, and improving metadata update functionality by replacing a `Drawer` with a `Sheet` for better user experience.
### Detailed summary
- Corrected typo from `Aidrop` to `Airdrop` in `airdrop-tab.tsx` and `airdrop-button.tsx`.
- Added `className="text-left"` to `SheetTitle` in several components for consistent text alignment.
- Replaced `Drawer` with `Sheet` in `update-metadata-tab.tsx` to improve UI.
- Modified state management for opening/closing the metadata update sheet.
- Enhanced error handling and user feedback with `toast` notifications in `update-metadata-form.tsx`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
kien/remove-drawer-marketplace-listing-form
branch
from
f2a7bad to
c3f2404
Compare
gregfromstl
force-pushed
the
kien/remove-drawer-erc1155-update-metadata
branch
from
ca1f2d2 to
412fb5d
Compare
Base automatically changed from
kien/remove-drawer-marketplace-listing-form
to
main
November 2, 2024 02:15
graphite-app
bot
deleted the
kien/remove-drawer-erc1155-update-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the UI consistency and functionality of various components in the dashboard by standardizing titles and updating modal implementations for NFT metadata updates.
Detailed summary
AidroptoAirdropinairdrop-tab.tsxandairdrop-button.tsx.className="text-left"toSheetTitlein several components for consistent text alignment.DrawerwithSheetinupdate-metadata-tab.tsxfor a new modal implementation.useState.UpdateNftMetadataform.update-metadata-form.tsx.