[Dashboard] Remove Drawer & cleanup marketplace listing form #5265

kien-ngo · 2024-11-01T22:20:03Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR refactors the CreateListingButton and CreateListingsForm components to replace the Drawer UI component with a Sheet component for better user experience. It also enhances form handling and error management.

Detailed summary

Replaced Drawer with Sheet in CreateListingButton.
Updated state management for opening and closing the form.
Modified CreateListingsForm to accept actionText and setOpen props.
Improved error handling with toast.promise for async operations.
Added a fixed button for form submission and cancellation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

graphite-app · 2024-11-01T22:20:07Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

vercel · 2024-11-01T22:20:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 2, 2024 2:13am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Nov 2, 2024 2:13am
thirdweb_playground	⬜️ Skipped (Inspect)	Nov 2, 2024 2:13am
wallet-ui	⬜️ Skipped (Inspect)	Nov 2, 2024 2:13am

changeset-bot · 2024-11-01T22:20:08Z

⚠️ No Changeset found

Latest commit: c3f2404

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kien-ngo · 2024-11-01T22:20:20Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

codecov · 2024-11-01T22:21:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.36%. Comparing base (5484075) to head (c3f2404).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5265   +/-   ##
=======================================
  Coverage   45.36%   45.36%           
=======================================
  Files        1067     1067           
  Lines       55449    55449           
  Branches     3989     3989           
=======================================
  Hits        25157    25157           
  Misses      29601    29601           
  Partials      691      691

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 5484075
packages	`40.41% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-11-01T22:23:33Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43 KB (0%)	861 ms (0%)	542 ms (-27.29% 🔽)	1.5 s
thirdweb (cjs)	102.88 KB (0%)	2.1 s (0%)	2.2 s (+74.62% 🔺)	4.3 s
thirdweb (minimal + tree-shaking)	4.84 KB (0%)	97 ms (0%)	41 ms (-47.66% 🔽)	137 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	179 ms (+560.69% 🔺)	189 ms
thirdweb/react (minimal + tree-shaking)	17 KB (0%)	341 ms (0%)	435 ms (+259.72% 🔺)	775 ms

gregfromstl · 2024-11-02T01:14:49Z

Merge activity

Nov 1, 9:14 PM EDT: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 1, 9:29 PM EDT: A user added this pull request to the Graphite merge queue.
Nov 1, 10:15 PM EDT: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on refactoring the `CreateListingButton` and `CreateListingsForm` components to replace the `Drawer` component with a `Sheet` component for better user interface interaction in the marketplace. ### Detailed summary - Replaced `Drawer` with `Sheet` in `CreateListingButton`. - Updated state management for opening/closing the form. - Modified button and form structure to align with `Sheet` component. - Added `actionText` and `setOpen` props to `CreateListingsForm`. - Introduced toast notifications for transaction promises in `CreateListingsForm`. - Implemented a fixed button section for form submission and cancellation. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 22:20 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 22:20 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 22:20 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 1, 2024

This was referenced Nov 1, 2024

[Dashboard] Remove chakra: BatchUpload drawer + other minor changes #5259

Merged

[Dashboard] Remove Drawer from mintTo form #5263

Merged

kien-ngo mentioned this pull request Nov 1, 2024

[Dashboard] Remove Drawer from LazyMint form #5264

Merged

kien-ngo changed the title ~~[Dashboard] Remove Drawer & cleanup marketplace listnig form~~ [Dashboard] Remove Drawer & cleanup marketplace listing form Nov 1, 2024

kien-ngo marked this pull request as ready for review November 1, 2024 22:20

kien-ngo requested review from MananTank, jnsdls and joaquim-verges as code owners November 1, 2024 22:20

vercel bot deployed to Preview – thirdweb-www November 1, 2024 22:30 View deployment

kien-ngo force-pushed the kien/remove-drawer-lazyMint-form branch from 7bc7ef5 to 9e70db2 Compare November 1, 2024 23:34

kien-ngo force-pushed the kien/remove-drawer-marketplace-listing-form branch from ea33c47 to 1e517b9 Compare November 1, 2024 23:34

vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 23:35 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 23:35 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 23:35 Inactive

kien-ngo force-pushed the kien/remove-drawer-lazyMint-form branch from 9e70db2 to aca761b Compare November 1, 2024 23:36

kien-ngo force-pushed the kien/remove-drawer-marketplace-listing-form branch from 1e517b9 to 6ce4e43 Compare November 1, 2024 23:36

vercel bot temporarily deployed to Preview – wallet-ui November 1, 2024 23:36 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 1, 2024 23:36 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 1, 2024 23:36 Inactive

vercel bot deployed to Preview – thirdweb-www November 1, 2024 23:53 View deployment

kien-ngo mentioned this pull request Nov 2, 2024

[Dashboard] Remove Drawer from ERC1155 udpate-metadata form #5269

Merged

jnsdls approved these changes Nov 2, 2024

View reviewed changes

kien-ngo force-pushed the kien/remove-drawer-lazyMint-form branch from aca761b to c488825 Compare November 2, 2024 01:09

kien-ngo force-pushed the kien/remove-drawer-marketplace-listing-form branch from 6ce4e43 to f2a7bad Compare November 2, 2024 01:09

vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 01:09 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 01:09 Inactive

vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 01:09 Inactive

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 2, 2024

vercel bot deployed to Preview – thirdweb-www November 2, 2024 01:28 View deployment

gregfromstl force-pushed the kien/remove-drawer-lazyMint-form branch from c488825 to 5484075 Compare November 2, 2024 01:56

gregfromstl force-pushed the kien/remove-drawer-marketplace-listing-form branch from f2a7bad to c3f2404 Compare November 2, 2024 01:56

vercel bot temporarily deployed to Preview – wallet-ui November 2, 2024 01:56 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground November 2, 2024 01:56 Inactive

vercel bot temporarily deployed to Preview – docs-v2 November 2, 2024 01:56 Inactive

vercel bot deployed to Preview – thirdweb-www November 2, 2024 02:13 View deployment

Base automatically changed from kien/remove-drawer-lazyMint-form to main November 2, 2024 02:14

graphite-app bot merged commit c3f2404 into main Nov 2, 2024
29 of 31 checks passed

graphite-app bot deleted the kien/remove-drawer-marketplace-listing-form branch November 2, 2024 02:15

vercel bot temporarily deployed to Production – thirdweb_playground November 2, 2024 02:15 Inactive

vercel bot temporarily deployed to Production – docs-v2 November 2, 2024 02:15 Inactive

vercel bot temporarily deployed to Production – wallet-ui November 2, 2024 02:15 Inactive

vercel bot deployed to Production – thirdweb-www November 2, 2024 02:28 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dashboard] Remove Drawer & cleanup marketplace listing form #5265

[Dashboard] Remove Drawer & cleanup marketplace listing form #5265

kien-ngo commented Nov 1, 2024 •

edited by pr-codex bot

Loading

Uh oh!

graphite-app bot commented Nov 1, 2024

Uh oh!

vercel bot commented Nov 1, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 1, 2024 •

edited

Loading

Uh oh!

kien-ngo commented Nov 1, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 1, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 1, 2024 •

edited

Loading

Uh oh!

gregfromstl commented Nov 2, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Dashboard] Remove Drawer & cleanup marketplace listing form #5265

[Dashboard] Remove Drawer & cleanup marketplace listing form #5265

Conversation

kien-ngo commented Nov 1, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

graphite-app bot commented Nov 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

vercel bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

kien-ngo commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Nov 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

gregfromstl commented Nov 2, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kien-ngo commented Nov 1, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 1, 2024 •

edited

Loading

changeset-bot bot commented Nov 1, 2024 •

edited

Loading

kien-ngo commented Nov 1, 2024 •

edited

Loading

codecov bot commented Nov 1, 2024 •

edited

Loading

github-actions bot commented Nov 1, 2024 •

edited

Loading

gregfromstl commented Nov 2, 2024 •

edited by graphite-app bot

Loading