[Ecosystem Portal] Refactor: Update the middleware to redirect to subroutes rather than rewrites #5405
Conversation
gregfromstl
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| const userAddress = await getCurrentUser(); | ||
| if (userAddress) { | ||
| redirect(`/wallet/${userAddress}`); | ||
| redirect(`${ecosystem}/wallet/${userAddress}`); |
There was a problem hiding this comment.
The redirect path is missing a leading forward slash, which could cause navigation issues. The correct path should be:
redirect(`/${ecosystem}/wallet/${userAddress}`)Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5405 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1068 1068
Lines 55433 55433
Branches 4000 4000
=======================================
Hits 25112 25112
Misses 29634 29634
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
CNCT-2344
PR-Codex overview
This PR focuses on updating the routing and authentication mechanisms in the wallet application to support ecosystem-based paths and improve the logout functionality.
Detailed summary
ecosystemin wallet URLs.authedOnlyfunction to acceptecosystemas a parameter.ConnectButtonto log out users on disconnect.ecosystemin parameters.