fix: Handle zero maxPriorityFeePerGas in 712 transactions

[joaquim-verges]

Problem solved

Short description of the bug fixed or feature added

---

PR-Codex overview

This PR focuses on handling scenarios where maxPriorityFeePerGas can be zero in EIP-712 transactions within the thirdweb package.

Detailed summary

• Updated the condition to check for undefined values for gas, maxFeePerGas, and maxPriorityFeePerGas in send-eip712-transaction.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2024 8:47am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2024 8:47am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2024 8:47am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2024 8:47am

[changeset-bot]

🦋 Changeset detected

Latest commit: 209b0ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
thirdweb	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[joaquim-verges]

• fix: Handle zero maxPriorityFeePerGas in 712 transactions #5531 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	47.92 KB (0%)	959 ms (0%)	3.3 s (+67.59% 🔺)	4.3 s
thirdweb (cjs)	107.33 KB (+0.06% 🔺)	2.2 s (+0.06% 🔺)	7 s (+17.95% 🔺)	9.2 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	110 ms (-67.36% 🔽)	221 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	116 ms (-71.2% 🔽)	126 ms
thirdweb/react (minimal + tree-shaking)	18.28 KB (0%)	366 ms (0%)	572 ms (+24.6% 🔺)	938 ms

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.19%. Comparing base (f64e025) to head (209b0ae).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...nsaction/actions/zksync/send-eip712-transaction.ts	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5531      +/-   ##
==========================================
- Coverage   46.20%   46.19%   -0.01%     
==========================================
  Files        1080     1080              
  Lines       58569    58573       +4     
  Branches     3929     3929              
==========================================
  Hits        27060    27060              
- Misses      30826    30830       +4     
  Partials      683      683              

Flag	Coverage Δ		*Carryforward flag
legacy_packages	65.68% <ø> (ø)		Carriedforward from f64e025
packages	41.75% <0.00%> (-0.01%)	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...nsaction/actions/zksync/send-eip712-transaction.ts	6.62% <0.00%> (-0.17%)	⬇️