Skip to content

fix: Handle zero maxPriorityFeePerGas in 712 transactions #5531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: Handle zero maxPriorityFeePerGas in 712 transactions #5531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wild-games-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Handle 0 value for maxPriorityFeePerGas in 712 transactions
6 changes: 5 additions & 1 deletion packages/thirdweb/src/transaction/actions/zksync/send-eip712-transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,11 @@
resolvePromisedValue(transaction.eip712),
]);
let gasPerPubdata = eip712?.gasPerPubdata;
if (!gas || !maxFeePerGas || !maxPriorityFeePerGas) {
if (
gas === undefined ||
maxFeePerGas === undefined ||
maxPriorityFeePerGas === undefined
) {

Check warning on line 180 in packages/thirdweb/src/transaction/actions/zksync/send-eip712-transaction.ts

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/transaction/actions/zksync/send-eip712-transaction.ts#L176-L180 

Added lines #L176 - L180 were not covered by tests
const rpc = getRpcClient(transaction);
const params = await formatTransaction({ transaction, from });
const result = (await rpc({
Expand Down
Loading