Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 27, 2024

PR-Codex overview

This PR focuses on refactoring the thirdweb package to utilize the ox library for signature and typed data handling, enhancing the code's modularity and maintainability.

Detailed summary

  • Removed the domain: chainId hex test in sign-typed-data.test.ts.
  • Updated imports to use the ox library in various files.
  • Changed the implementation of sign and signTypedData functions to utilize ox__Secp256k1 and ox__TypedData.
  • Modified signatureToHex to work with the new signature structure.
  • Adjusted tests to validate new functionality with ox methods.
  • Updated coinbase-web.ts to integrate ox for hex validation and typed data serialization.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 27, 2024

@vercel
Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 6:42pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 6:42pm
thirdweb-www ❌ Failed (Inspect) Dec 1, 2024 6:42pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 6:42pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024

⚠️ No Changeset found

Latest commit: daa4fbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 48.14 KB (+0.47% 🔺) 963 ms (+0.47% 🔺) 841 ms (+92.76% 🔺) 1.9 s
thirdweb (cjs) 108.63 KB (+1.27% 🔺) 2.2 s (+1.27% 🔺) 930 ms (-2.43% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 165 ms (+273.56% 🔺) 277 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 38 ms (+55.28% 🔺) 48 ms
thirdweb/react (minimal + tree-shaking) 18.47 KB (+1.06% 🔺) 370 ms (+1.06% 🔺) 195 ms (+121.69% 🔺) 565 ms

@socket-security
Copy link

socket-security bot commented Dec 1, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] network +5 5.74 MB jmoxey

🚮 Removed packages: npm/[email protected]

View full report↗︎

@codecov
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 75.30864% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (5-dot-ox@e2b2c1e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ages/thirdweb/src/wallets/coinbase/coinbase-web.ts 27.27% 8 Missing ⚠️
packages/thirdweb/src/wallets/smart/index.ts 20.00% 8 Missing ⚠️
.../thirdweb/src/utils/signatures/signature-to-hex.ts 83.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             5-dot-ox    #5532   +/-   ##
===========================================
  Coverage            ?   46.47%           
===========================================
  Files               ?     1082           
  Lines               ?    58728           
  Branches            ?     3962           
===========================================
  Hits                ?    27296           
  Misses              ?    30747           
  Partials            ?      685           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (?) Carriedforward from c54fc70
packages 42.11% <75.30%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...b/src/utils/signatures/helpers/parse-typed-data.ts 100.00% <100.00%> (ø)
...ages/thirdweb/src/utils/signatures/sign-message.ts 88.00% <100.00%> (ø)
...s/thirdweb/src/utils/signatures/sign-typed-data.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/utils/signatures/sign.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/wallets/private-key.ts 100.00% <100.00%> (ø)
.../thirdweb/src/utils/signatures/signature-to-hex.ts 84.61% <83.33%> (ø)
...ages/thirdweb/src/wallets/coinbase/coinbase-web.ts 32.43% <27.27%> (ø)
packages/thirdweb/src/wallets/smart/index.ts 16.63% <20.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants