-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Refactor: Migrate signatures to Ox #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Refactor: Migrate signatures to Ox #5532
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
943dceb to
7ba458a
Compare
size-limit report 📦
|
packages/thirdweb/src/extensions/erc1271/checkContractWalletSignedTypedData.ts
Show resolved
Hide resolved
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 5-dot-ox #5532 +/- ##
===========================================
Coverage ? 46.47%
===========================================
Files ? 1082
Lines ? 58728
Branches ? 3962
===========================================
Hits ? 27296
Misses ? 30747
Partials ? 685
*This pull request uses carry forward flags. Click here to find out more.
|
PR-Codex overview
This PR focuses on refactoring the
thirdwebpackage to utilize theoxlibrary for signature and typed data handling, enhancing the code's modularity and maintainability.Detailed summary
domain: chainId hextest insign-typed-data.test.ts.oxlibrary in various files.signandsignTypedDatafunctions to utilizeox__Secp256k1andox__TypedData.signatureToHexto work with the new signature structure.oxmethods.coinbase-web.tsto integrateoxfor hex validation and typed data serialization.