Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 30, 2024

part of DASH-388


PR-Codex overview

This PR primarily focuses on replacing the usage of the Text component from tw-components with standard HTML <p> tags across various files to simplify the code and improve consistency.

Detailed summary

  • Removed imports of Text from tw-components in multiple files.
  • Replaced instances of <Text> with <p> tags in AmbassadorCards, mission.tsx, nfts-owned.tsx, system.tsx, sources-accordion.tsx, batch-table.tsx, claimer-selection.tsx, create-account-button.tsx, sdk.tsx, storage.tsx, airdrop-tab.tsx, rpc-edge.tsx, and token-id.tsx.
  • Updated styles for <p> tags to match the previous Text component styles where necessary.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2024

⚠️ No Changeset found

Latest commit: ebf94a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@kien-ngo kien-ngo marked this pull request as ready for review November 30, 2024 18:51
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 30, 2024
Copy link
Contributor Author

kien-ngo commented Nov 30, 2024

@codecov
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.31%. Comparing base (57fa96b) to head (ebf94a6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5540   +/-   ##
=======================================
  Coverage   46.31%   46.31%           
=======================================
  Files        1082     1082           
  Lines       58672    58672           
  Branches     3955     3955           
=======================================
  Hits        27174    27174           
  Misses      30815    30815           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 57fa96b
packages 41.90% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 30, 2024 18:53 Inactive
@vercel
Copy link

vercel bot commented Nov 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:54am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 2, 2024 11:54am
thirdweb_playground ⬜️ Skipped (Inspect) Dec 2, 2024 11:54am
wallet-ui ⬜️ Skipped (Inspect) Dec 2, 2024 11:54am

@vercel vercel bot temporarily deployed to Preview – docs-v2 November 30, 2024 18:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 30, 2024 18:53 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 306 ms (+5.41% 🔺) 1.3 s
thirdweb (cjs) 107.33 KB (0%) 2.2 s (0%) 497 ms (-21.11% 🔽) 2.7 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 29 ms (+93.75% 🔺) 141 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 5 ms (+32.44% 🔺) 15 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 93 ms (+70.18% 🔺) 459 ms

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comments

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make a ticket in linear to associate with this, otherwise looks good

@linear
Copy link

linear bot commented Dec 2, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants