[Dashboard] Remove chakra-ui from snapshot-upload #5543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
MananTank,
jnsdls and
joaquim-verges
as code owners
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...board)/(chain)/[chain_id]/[contractAddress]/_components/claim-conditions/snapshot-upload.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
=======================================
Coverage 46.31% 46.32%
=======================================
Files 1082 1082
Lines 58672 58672
Branches 3955 3950 -5
=======================================
+ Hits 27174 27178 +4
+ Misses 30815 30811 -4
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
size-limit report 📦
|
jnsdls
changed the base branch from
kien/remove-tw-component-1
to
graphite-base/5543
jnsdls
force-pushed
the
graphite-base/5543
branch
from
03468c0 to
ebf94a6
Compare
jnsdls
force-pushed
the
kien/remove-chakra-snapshot-upload
branch
from
37c933f to
f115b17
Compare
|
jnsdls
force-pushed
the
kien/remove-chakra-snapshot-upload
branch
from
f115b17 to
e37db1d
Compare
kien-ngo
force-pushed
the
kien/remove-chakra-snapshot-upload
branch
from
33eb953 to
fb19ac2
Compare
kien-ngo
commented
Dec 2, 2024
| * }); | ||
| * ``` | ||
| * Result: `0.0000057` (a number) | ||
| * Result: `{ result: 0.0000057 }` |
Contributor
Author
There was a problem hiding this comment.
Need to sneak in this fix!
kien-ngo
commented
Dec 2, 2024
| * }); | ||
| * | ||
| * // Result: 3404.11 | ||
| * // Result: `{ result: 3404.11 }` |
Contributor
Author
There was a problem hiding this comment.
Need to sneak in this fix!
MananTank
approved these changes
Dec 2, 2024
Contributor
Merge activity
|
part of DASH-388 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the return types in the `convertFiatToCrypto` and `convertCryptoToFiat` functions to return objects instead of plain numbers. Additionally, it modifies the `SnapshotUpload` component to replace `Link` elements with `a` tags and adjusts the layout for better styling. ### Detailed summary - Changed return type of `convertFiatToCrypto` to `{ result: 0.0000057 }`. - Changed return type of `convertCryptoToFiat` to `{ result: 3404.11 }`. - Replaced `Link` components with `a` tags in `SnapshotUpload`. - Adjusted layout and styling in `SnapshotUpload` for improved design. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/remove-chakra-snapshot-upload
branch
from
fb19ac2 to
4ae50f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of DASH-388
PR-Codex overview
This PR focuses on updating the return types in the
convertFiatToCryptoandconvertCryptoToFiatfunctions to return objects instead of plain numbers. Additionally, it refactors theSnapshotUploadcomponent to replaceFlexcomponents withdivelements and updateLinkcomponents toaelements for better semantics.Detailed summary
convertFiatToCryptoto{ result: number }.convertCryptoToFiatto{ result: number }.Flexcomponents withdivelements inSnapshotUploadfor layout.Linkcomponents toaelements inSnapshotUploadfor semantic correctness.