Skip to content

fix: defaultChainId should be validated in refine #5638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix: defaultChainId should be validated in refine #5638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .../~/ecosystem/[slug]/(active)/configuration/components/client/auth-options-form.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,11 @@ export function AuthOptionsForm({ ecosystem }: { ecosystem: Ecosystem }) {
.optional(),
useSmartAccount: z.boolean(),
sponsorGas: z.boolean(),
defaultChainId: z.coerce.number({
invalid_type_error: "Please enter a valid chain ID",
}),
defaultChainId: z.coerce
.number({
invalid_type_error: "Please enter a valid chain ID",
})
.optional(),
accountFactoryType: z.enum(["v0.6", "v0.7", "custom"]),
customAccountFactoryAddress: z.string().optional(),
})
Expand All @@ -108,6 +110,18 @@ export function AuthOptionsForm({ ecosystem }: { ecosystem: Ecosystem }) {
path: ["customAccountFactoryAddress"],
},
)
.refine(
(data) => {
if (data.useSmartAccount && (data.defaultChainId ?? 0) <= 0) {
return false;
}
return true;
},
{
message: "Please enter a valid chain ID",
path: ["defaultChainId"],
},
)
.refine(
(data) => {
if (data.useCustomAuth && !data.customAuthEndpoint) {
Expand Down
2 changes: 1 addition & 1 deletion ...ecosystem/[slug]/(active)/configuration/components/client/update-partner-modal.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function UpdatePartnerModal({

return (
<Dialog open={open} onOpenChange={setOpen}>
<DialogTrigger>{children}</DialogTrigger>
<DialogTrigger asChild>{children}</DialogTrigger>
<DialogContent className="z-[10001]" dialogOverlayClassName="z-[10000]">
<DialogHeader className="mb-2">
<DialogTitle>Update {partner.name}</DialogTitle>
Expand Down
Loading