fix: defaultChainId should be validated in refine
#5638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
MananTank,
jakubkrehel,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5638 +/- ##
=======================================
Coverage 47.82% 47.82%
=======================================
Files 1088 1088
Lines 56661 56661
Branches 4305 4305
=======================================
Hits 27099 27099
Misses 28864 28864
Partials 698 698
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Dec 6, 2024
ElasticBottle
added a commit
that referenced
this pull request
Dec 6, 2024
https://linear.app/thirdweb/issue/DASH-546/can-not-update-ecosystem-settings-form-if-default-chain-id-is-not-set <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the `update-partner-modal.client.tsx` and `auth-options-form.client.tsx` components by modifying the `DialogTrigger` and enhancing validation logic for the `defaultChainId` field. ### Detailed summary - Changed `DialogTrigger` to use `asChild` prop in `update-partner-modal.client.tsx`. - Made `defaultChainId` optional and adjusted its validation error handling in `auth-options-form.client.tsx`. - Added a new refinement rule to validate `defaultChainId` based on `useSmartAccount`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/fix-ecosystem-saving
branch
from
ce66e9b to
2c43c64
Compare
graphite-app
bot
removed
the
merge-queue
ElasticBottle
added
the
merge-queue
https://linear.app/thirdweb/issue/DASH-546/can-not-update-ecosystem-settings-form-if-default-chain-id-is-not-set <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the `update-partner-modal.client.tsx` and `auth-options-form.client.tsx` components. It modifies the dialog trigger and updates the validation logic for the form, ensuring better handling of the `defaultChainId` field. ### Detailed summary - Updated `<DialogTrigger>` in `update-partner-modal.client.tsx` to use `asChild`. - Modified `defaultChainId` in `auth-options-form.client.tsx` to be optional. - Added a refinement check to validate `defaultChainId` based on `useSmartAccount` in `auth-options-form.client.tsx`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/fix-ecosystem-saving
branch
from
2c43c64 to
5a2cfef
Compare
graphite-app
bot
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/DASH-546/can-not-update-ecosystem-settings-form-if-default-chain-id-is-not-set
PR-Codex overview
This PR primarily focuses on enhancing the validation logic in the
AuthOptionsFormcomponent and making a minor adjustment to theDialogTriggerin theupdate-partner-modal.client.tsx.Detailed summary
DialogTriggerto useasChildprop inupdate-partner-modal.client.tsx.defaultChainIdto be optional inauth-options-form.client.tsx.defaultChainIdbased onuseSmartAccountinauth-options-form.client.tsx.