use social SDK for publisher page #5639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c8dfeb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
jnsdls
requested review from
MananTank,
edwardysun,
gregfromstl,
jakubkrehel and
joaquim-verges
as code owners
github-actions
bot
added
Dashboard
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jnsdls
force-pushed
the
12-05-use_social_sdk_for_publisher_page
branch
2 times, most recently
from
e447da3 to
fc14c23
Compare
jnsdls
added
the
DO NOT MERGE
Graphite App
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5639 +/- ##
=======================================
Coverage 47.80% 47.80%
=======================================
Files 1090 1090
Lines 56691 56694 +3
Branches 4304 4303 -1
=======================================
+ Hits 27100 27103 +3
Misses 28893 28893
Partials 698 698
*This pull request uses carry forward flags. Click here to find out more.
|
jnsdls
force-pushed
the
12-05-use_social_sdk_for_publisher_page
branch
from
fc14c23 to
f77a1b8
Compare
joaquim-verges
approved these changes
Dec 6, 2024
Contributor
Merge activity
|
jnsdls
added a commit
that referenced
this pull request
Dec 6, 2024
closes: DASH-547 <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on removing unused components and optimizing existing code related to publisher profiles and social media integration. It also introduces improvements to error handling and modifies the account components to avoid retrying on failures. ### Detailed summary - Deleted several unused icon and component files. - Set `retry: false` for account components in `thirdweb`. - Added `replaceDeployerAddress` function to `publisher-utils`. - Refactored profile handling to utilize social profiles. - Removed unused profile schema definitions. - Updated `ProfileUI` to use `ProfileHeader` for displaying user info. - Simplified `ContractPublisher` to use `AccountProvider`. - Enhanced error handling in various components. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
12-05-use_social_sdk_for_publisher_page
branch
from
f77a1b8 to
c8dfeb7
Compare
closes: DASH-547 <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on removing unused components and code, updating the handling of publisher profiles, and enhancing the user interface components related to account and publisher display. ### Detailed summary - Deleted unused files: `MetaIcon.tsx`, `MediumIcon.tsx`, `TelegramIcon.tsx`, `edit-profile.tsx`, `masked-avatar.tsx`, `PublisherSocials.tsx`. - Updated `retry` option to `false` in several `queryOptions`. - Refactored publisher profile fetching and display logic. - Introduced `replaceDeployerAddress` function for address formatting. - Updated `ProfileUI` to use `ProfileHeader` component. - Enhanced `ContractPublisher` component with `AccountProvider`. - Removed console logging and unused variables throughout the code. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
12-05-use_social_sdk_for_publisher_page
branch
from
c8dfeb7 to
ed0886a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: DASH-547
PR-Codex overview
This PR primarily focuses on removing obsolete components and modifying existing ones to streamline the codebase. It introduces changes to the handling of publisher profiles and social media integration while enhancing the user interface components.
Detailed summary
MetaIcon,MediumIcon, andTelegramIcon.retryoption tofalsein multiplequeryOptions.ProfileUIby integratingProfileHeader.AccountAvatarandAccountNamecomponents.replaceDeployerAddressfunction for better address formatting.