Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 6, 2024

closes: CNCT-2563


PR-Codex overview

This PR updates various dependencies to ensure compatibility with react version 19.0.0, including changes to @types/react and several package versions across the project.

Detailed summary

  • Updated @types/react and @types/react-dom to 19.0.0.
  • Changed react and react-dom versions to 19.0.0 across multiple packages.
  • Updated next from 15.0.3 to 15.0.4.
  • Increased shiki version from 1.22.2 to 1.24.0.
  • Updated @next/eslint-plugin-next and @next/bundle-analyzer to 15.0.4.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: 5070e76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:38am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:38am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:38am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:38am

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

jnsdls commented Dec 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages Ecosystem Portal Involves changes to the Ecosystem Portal SDK Involves changes to the thirdweb SDK labels Dec 6, 2024
@linear
Copy link

linear bot commented Dec 6, 2024

@jnsdls jnsdls marked this pull request as ready for review December 6, 2024 00:46
@jnsdls jnsdls requested a review from a team as a code owner December 6, 2024 00:46
@jnsdls jnsdls requested a review from a team December 6, 2024 00:46
@socket-security
Copy link

socket-security bot commented Dec 6, 2024

@socket-security
Copy link

socket-security bot commented Dec 6, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Possible typosquat attack npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.72 KB (0%) 915 ms (0%) 2.8 s (+39.23% 🔺) 3.8 s
thirdweb (cjs) 106.26 KB (0%) 2.2 s (0%) 5.7 s (-22.76% 🔽) 7.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 236 ms (+56.83% 🔺) 348 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 100 ms (+8.04% 🔺) 110 ms
thirdweb/react (minimal + tree-shaking) 18.74 KB (0%) 375 ms (0%) 393 ms (+29.53% 🔺) 767 ms

@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.82%. Comparing base (d1716fc) to head (5070e76).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5640      +/-   ##
==========================================
- Coverage   47.83%   47.82%   -0.01%     
==========================================
  Files        1088     1088              
  Lines       56661    56661              
  Branches     4307     4305       -2     
==========================================
- Hits        27104    27099       -5     
- Misses      28859    28864       +5     
  Partials      698      698              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d1716fc
packages 43.58% <ø> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@jnsdls jnsdls changed the base branch from 12-05-use_social_sdk_for_publisher_page to graphite-base/5640 December 6, 2024 01:33
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/5640 to main December 6, 2024 02:10
@graphite-app graphite-app bot requested a review from edwardysun as a code owner December 6, 2024 02:10
jnsdls added a commit that referenced this pull request Dec 6, 2024
closes: CNCT-2563

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating various package dependencies to ensure compatibility with `react 19`, including the removal of release candidate versions and the addition of explicit peer dependencies.

### Detailed summary
- Updated `@types/react` and `@types/react-dom` to version `19.0.0`.
- Changed `next` version from `15.0.3` to `15.0.4`.
- Updated `react` and `react-dom` to version `19.0.0`.
- Incremented `@next/eslint-plugin-next` and `@next/mdx` to `15.0.4`.
- Updated `shiki` to version `1.24.0` in multiple packages.

> The following files were skipped due to too many changes: `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-05-update_next_react_versions branch from ee834bc to 679e333 Compare December 6, 2024 02:11
closes: CNCT-2563

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates various dependencies to ensure compatibility with `react 19`, including explicitly setting peer dependencies and updating package versions across multiple files.

### Detailed summary
- Updated `@types/react` and `@types/react-dom` to `19.0.0`.
- Changed `react` and `react-dom` versions to `19.0.0`.
- Updated `next` versions from `15.0.3` to `15.0.4`.
- Updated `shiki` versions from `1.22.2` to `1.24.0`.
- Updated `@next/eslint-plugin-next` and `@next/mdx` versions to `15.0.4`.

> The following files were skipped due to too many changes: `pnpm-lock.yaml`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants