Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 19, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces enhancements to the ToolTipLabel and SelectTrigger components, adds new properties, and refines the ParameterSection functionality. It also introduces a new ParameterInput component to streamline input handling.

Detailed summary

  • Added contentClassName prop to ToolTipLabel.
  • Updated className in TooltipContent to include props.contentClassName.
  • Extended SelectTrigger to accept chevronClassName.
  • Improved error handling display in RequestConfigSection.
  • Introduced ParameterInput component for better parameter handling.
  • Enhanced tooltip display logic with showTip and example handling in ParameterSection.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 19, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 58b75d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 9:34pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 19, 2024 9:34pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 19, 2024 9:34pm
wallet-ui ⬜️ Skipped (Inspect) Dec 19, 2024 9:34pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 18:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 18:22 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 19, 2024
@MananTank MananTank changed the title [TOOL-2804] Render Select for Parameters with enum schema + Show Examples [TOOL-2804] Insight Playground: Render Select for Parameters with enum schema + Show Examples Dec 19, 2024
@MananTank MananTank marked this pull request as ready for review December 19, 2024 18:22
Copy link
Member Author

MananTank commented Dec 19, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (d7d9415) to head (58b75d1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5805   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4824     4824           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d7d9415
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 4 s (+49.74% 🔺) 4.9 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 7.7 s (-2.9% 🔽) 9.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 413 ms (-19.28% 🔽) 525 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 173 ms (+319.18% 🔺) 183 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 586 ms (+11.46% 🔺) 968 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 19, 2024

Merge activity

@MananTank MananTank force-pushed the 12-19-_tool-2800_use_openapiv3_types_in_insight_playground branch from 9174ffa to 216f069 Compare December 19, 2024 20:59
MananTank added a commit that referenced this pull request Dec 19, 2024
…m schema + Show Examples (#5805)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces enhancements to the `ToolTipLabel` and `SelectTrigger` components, adds new props for better customization, and refines the `ParameterSection` to improve user experience with error handling and example display.

### Detailed summary
- Added `contentClassName` prop to `ToolTipLabel` for custom styling.
- Updated `SelectTrigger` to accept `chevronClassName` for icon customization.
- Enhanced `RequestConfigSection` with error display logic.
- Introduced `ParameterInput` component for better handling of parameter inputs.
- Improved tooltip display with examples in `ParameterSection`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-19-_tool-2804_render_select_for_parameters_with_enum_schema_show_examples branch from 6f1a918 to ed047fd Compare December 19, 2024 21:00
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 21:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 21:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 21:00 Inactive
…m schema + Show Examples (#5805)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `ToolTipLabel` and `SelectTrigger` components, adding new props for customization. It also introduces a new `ParameterInput` component to streamline input handling for parameters with enums, improving the overall user experience in forms.

### Detailed summary
- Added `contentClassName` prop to `ToolTipLabel` for custom styling.
- Updated `SelectTrigger` to accept `chevronClassName` prop for customization.
- Introduced `ParameterInput` component to handle parameter inputs with enums.
- Enhanced form error handling and display logic in `RequestConfigSection` and `ParameterSection`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-19-_tool-2800_use_openapiv3_types_in_insight_playground branch from 216f069 to d7d9415 Compare December 19, 2024 21:26
@MananTank MananTank force-pushed the 12-19-_tool-2804_render_select_for_parameters_with_enum_schema_show_examples branch from ed047fd to 58b75d1 Compare December 19, 2024 21:26
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 19, 2024 21:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 21:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 21:26 Inactive
Base automatically changed from 12-19-_tool-2800_use_openapiv3_types_in_insight_playground to main December 19, 2024 21:35
@graphite-app graphite-app bot merged commit 58b75d1 into main Dec 19, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-19-_tool-2804_render_select_for_parameters_with_enum_schema_show_examples branch December 19, 2024 21:36
@vercel vercel bot temporarily deployed to Production – wallet-ui December 19, 2024 21:36 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 19, 2024 21:36 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 19, 2024 21:36 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www December 19, 2024 21:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants