[TOOL-2800] Insight Playground: Combine all filter query params in a group #5807
+41
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
joaquim-verges
approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5807 +/- ##
=======================================
Coverage 53.34% 53.34%
=======================================
Files 1101 1101
Lines 59124 59124
Branches 4824 4824
=======================================
Hits 31541 31541
Misses 26864 26864
Partials 719 719
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
Contributor
Merge activity
|
MananTank
force-pushed
the
12-19-_tool-2804_render_select_for_parameters_with_enum_schema_show_examples
branch
from
6f1a918 to
ed047fd
Compare
MananTank
added a commit
that referenced
this pull request
Dec 19, 2024
…group (#5807) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `RequestConfigSection` component by restructuring how parameters are categorized into `pathVariables`, `queryParams`, and `filterQueryParams`. It introduces a new `ParameterSection` for `filterQueryParams` and improves the styling of parameter sections. ### Detailed summary - Replaced direct filtering of `props.parameters` with a `useMemo` hook for better performance. - Added categorization of parameters into `pathVariables`, `queryParams`, and `filterQueryParams`. - Introduced a new `ParameterSection` for rendering `filterQueryParams`. - Updated the `ParameterSection` to accept a `className` prop for styling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-20-_tool-2800_insight_playground_combine_all_filter_query_params_in_a_group
branch
from
b5ff31e to
dc088f2
Compare
…group (#5807) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `RequestConfigSection` component by improving the handling of parameters. It introduces a new categorization for query parameters, separating them into general query parameters and filter query parameters, and updates the rendering logic accordingly. ### Detailed summary - Refactored parameter handling in `RequestConfigSection` using `useMemo`. - Introduced `filterQueryParams` to categorize parameters starting with "filter_". - Updated rendering to conditionally display `ParameterSection` for `filterQueryParams`. - Added `className` prop to `ParameterSection` for styling flexibility. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
12-19-_tool-2804_render_select_for_parameters_with_enum_schema_show_examples
branch
from
ed047fd to
58b75d1
Compare
MananTank
force-pushed
the
12-20-_tool-2800_insight_playground_combine_all_filter_query_params_in_a_group
branch
from
dc088f2 to
fd4664a
Compare
Base automatically changed from
12-19-_tool-2804_render_select_for_parameters_with_enum_schema_show_examples
to
main
December 19, 2024 21:36
graphite-app
bot
deleted the
12-20-_tool-2800_insight_playground_combine_all_filter_query_params_in_a_group
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR enhances the
RequestConfigSectioncomponent by restructuring how parameters are categorized, introducing a new grouping for filter query parameters, and improving the rendering of parameter sections.Detailed summary
pathandqueryparameters with a singleuseMemohook.filterQueryParamsthat captures parameters starting with "filter_".ParameterSectionforfilterQueryParams.ParameterSectionto accept an optionalclassNameprop.