Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 15, 2025

PR-Codex overview

This PR focuses on updating the EmbedSetup component to remove deprecated features and improve user guidance for creating client IDs and using embeds. It introduces alerts for deprecation, modifies form controls, and enhances the overall layout.

Detailed summary

  • Added an Alert for deprecated thirdweb NFT Embeds.
  • Removed useClipboard functionality and related components.
  • Updated form controls for listing and token IDs.
  • Added a section for creating a Client ID with improved guidance.
  • Introduced a new FormControl for selecting themes.
  • Enhanced layout with better structure and spacing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 15, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: ea34a97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 2:00am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 16, 2025 2:00am
thirdweb_playground ⬜️ Skipped (Inspect) Jan 16, 2025 2:00am
wallet-ui ⬜️ Skipped (Inspect) Jan 16, 2025 2:00am

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 15, 2025
Copy link
Member Author

MananTank commented Jan 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.68 KB (0%) 934 ms (0%) 3.8 s (+10.65% 🔺) 4.7 s
thirdweb (cjs) 116.72 KB (0%) 2.4 s (0%) 9.4 s (+36.59% 🔺) 11.7 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 501 ms (-9.55% 🔽) 613 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 91 ms (+74.91% 🔺) 101 ms
thirdweb/react (minimal + tree-shaking) 19.24 KB (0%) 385 ms (0%) 760 ms (-30.24% 🔽) 1.2 s

@MananTank MananTank force-pushed the 01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments branch from 3f4d3d2 to fdc528d Compare January 15, 2025 23:24
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 15, 2025 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 15, 2025 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 15, 2025 23:24 Inactive
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (a834199) to head (ea34a97).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5960   +/-   ##
=======================================
  Coverage   54.82%   54.82%           
=======================================
  Files        1150     1150           
  Lines       61194    61194           
  Branches     5154     5154           
=======================================
  Hits        33548    33548           
  Misses      26919    26919           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a834199
packages 52.47% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the base branch from TOOL-3075 to graphite-base/5960 January 16, 2025 00:15
@MananTank MananTank force-pushed the 01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments branch from fdc528d to d5e8dd3 Compare January 16, 2025 00:22
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 16, 2025 00:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 16, 2025 00:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 16, 2025 00:22 Inactive
@MananTank MananTank changed the base branch from graphite-base/5960 to main January 16, 2025 00:23
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 16, 2025

Merge activity

  • Jan 15, 7:23 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jan 15, 8:08 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 15, 8:20 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Jan 15, 8:52 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 15, 9:00 PM EST: A user merged this pull request with the Graphite merge queue.

@MananTank MananTank force-pushed the 01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments branch from d5e8dd3 to 8ca42c4 Compare January 16, 2025 00:24
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 16, 2025 00:24 Inactive
@MananTank MananTank changed the base branch from main to TOOL-3075 January 16, 2025 00:24
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 16, 2025 00:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 16, 2025 00:24 Inactive
@MananTank MananTank changed the base branch from TOOL-3075 to graphite-base/5960 January 16, 2025 01:08
@graphite-app graphite-app bot changed the base branch from graphite-base/5960 to main January 16, 2025 01:18
@MananTank MananTank force-pushed the 01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments branch from 8ca42c4 to 58b8f3a Compare January 16, 2025 01:43
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 16, 2025 01:43 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 16, 2025 01:43 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 16, 2025 01:43 Inactive
…ments (#5960)

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on updating the `EmbedSetup` component to enhance user experience by introducing a deprecation alert for NFT embeds, reorganizing the UI layout, and adding new configuration options.

### Detailed summary
- Added an `Alert` component indicating the deprecation of thirdweb NFT Embeds.
- Replaced `Flex` with `div` for layout simplification.
- Consolidated form controls for configuration and added new fields for `Client ID`, `RPC Url`, and `Gasless` options.
- Introduced a theme selection dropdown.
- Updated embed code section and preview area for clarity.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments branch from 58b8f3a to ea34a97 Compare January 16, 2025 01:52
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 16, 2025 01:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 16, 2025 01:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 16, 2025 01:52 Inactive
@graphite-app graphite-app bot merged commit ea34a97 into main Jan 16, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments branch January 16, 2025 02:00
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 16, 2025 02:00 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 January 16, 2025 02:00 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 16, 2025 02:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants