[TOOL-3056]: Add Engine transactions bar chart, Make shadcn table header sticky #5963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
size-limit report 📦
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...[team_slug]/(team)/~/engine/(instance)/[engineId]/overview/components/transactions-table.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5963 +/- ##
=======================================
Coverage 54.82% 54.82%
=======================================
Files 1150 1150
Lines 61194 61194
Branches 5154 5154
=======================================
Hits 33548 33548
Misses 26919 26919
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more. |
joaquim-verges
approved these changes
Jan 16, 2025
Member
joaquim-verges
left a comment
joaquim-verges
left a comment
There was a problem hiding this comment.
good start! lets merge and iterate
MananTank
force-pushed
the
01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments
branch
from
fdc528d to
d5e8dd3
Compare
MananTank
force-pushed
the
01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments
branch
from
d5e8dd3 to
8ca42c4
Compare
Contributor
Merge activity
|
MananTank
force-pushed
the
01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments
branch
from
8ca42c4 to
58b8f3a
Compare
…der sticky (#5963) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on enhancing the user interface and functionality of various components in the dashboard application, particularly around data visualization and table displays. ### Detailed summary - Updated `chartClassName` for better aspect ratio in multiple chart components. - Added `tableScrollableClassName` and `tableContainerClassName` to improve table layouts. - Modified text in `engine-overview.tsx` for clarity. - Introduced new props in `ThirdwebBarChart` for customizable tooltips and titles. - Implemented data processing logic in `TransactionsTable` for analytics display. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments
branch
from
58b8f3a to
ea34a97
Compare
Base automatically changed from
01-16-_tool-3090_dashboard_add_deprecated_alert_in_embeds_page_ui_adjustments
to
main
January 16, 2025 02:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the UI components in the dashboard by adjusting chart aspect ratios, adding scrollable table features, and improving the
ThirdwebBarChartcomponent with new props for better data visualization.Detailed summary
chartClassNameaspect ratios in various components toaspect-[1.5].tableScrollableClassNameprop inTWTablefor scrollable table functionality.ThirdwebBarChartwith new props:titleClassName,hideLabel, andtoolTipLabelFormatter.engine-overview.tsxto modify transaction description text.TransactionsTable.