[TOOL-3095] Portal: Enable Table of contents in Nebula pages, Adjust TOC component #5965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
Portal
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
MananTank
force-pushed
the
01-16-_tool-3095_portal_enable_table_of_contents_in_nebula_pages
branch
from
34dd160 to
a9a6840
Compare
MananTank
changed the title
MananTank
changed the title
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5965 +/- ##
=======================================
Coverage 54.83% 54.83%
=======================================
Files 1150 1150
Lines 61195 61195
Branches 5155 5155
=======================================
Hits 33554 33554
Misses 26914 26914
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more. |
gregfromstl
approved these changes
Jan 16, 2025
Contributor
Merge activity
|
MananTank
added a commit
that referenced
this pull request
Jan 16, 2025
…TOC component (#5965) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on improving the `Layout` component in `layout.tsx` and updating the styling of the `TOCLink` component in `TableOfContents.tsx`. ### Detailed summary - In `layout.tsx`, the `DocLayout` component's closing tag has been moved to wrap `{props.children}`. - In `TableOfContents.tsx`, the `data-active` class for the `Link` component has been changed from `text-accent-500` to `text-f-100`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
01-16-_tool-3095_portal_enable_table_of_contents_in_nebula_pages
branch
from
a9a6840 to
2ccbc14
Compare
…TOC component (#5965) <!-- start pr-codex --> ## PR-Codex overview This PR focuses on refining the `Layout` component's structure and updating the styling for the `TOCLink` component to enhance the user interface. ### Detailed summary - In `Layout`, the `DocLayout` component now wraps `props.children` directly without unnecessary line breaks. - In `TOCLink`, the `data-active` class styling was changed from `text-accent-500` to `text-f-100` for active links. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
01-16-_tool-3095_portal_enable_table_of_contents_in_nebula_pages
branch
from
2ccbc14 to
8d9854d
Compare
graphite-app
bot
deleted the
01-16-_tool-3095_portal_enable_table_of_contents_in_nebula_pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the layout rendering in the
Layoutcomponent and refining the styling of theTOCLinkcomponent.Detailed summary
Layout, theDocLayoutcomponent now directly wrapsprops.children, removing unnecessary line breaks.TOCLink, thedata-activeclass styling is updated fromtext-accent-500totext-f-100.