Skip to content

[TOOL-3095] Portal: Enable Table of contents in Nebula pages, Adjust TOC component #5965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[TOOL-3095] Portal: Enable Table of contents in Nebula pages, Adjust TOC component #5965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions apps/portal/src/app/nebula/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@ import { sidebar } from "./sidebar";

export default async function Layout(props: { children: React.ReactNode }) {
return (
<DocLayout
sideBar={sidebar}
editPageButton={true}
showTableOfContents={false}
>
<DocLayout sideBar={sidebar} editPageButton={true}>
{props.children}
</DocLayout>
);
Expand Down
4 changes: 3 additions & 1 deletion apps/portal/src/components/others/TableOfContents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ export function TableOfContentsSideBar(props: {
return;
}

setHideNav(false);

// when heading's intersection changes, update corresponding link's data-active attribute to true/false
const observer = new IntersectionObserver(
(entries) => {
Expand Down Expand Up @@ -175,7 +177,7 @@ function TOCLink(props: {
return (
<Link
className={cn(
"block overflow-hidden text-ellipsis font-medium text-f-300 transition-colors hover:text-f-100 data-[active='true']:text-accent-500",
"block overflow-hidden text-ellipsis font-medium text-f-300 transition-colors hover:text-f-100 data-[active='true']:text-f-100",
props.linkClassName,
)}
href={props.href}
Expand Down
Loading