Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 27, 2025


title: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

How to test

Unit tests, playground, etc.


PR-Codex overview

This PR focuses on improving the connection process to in-app wallets by ensuring that the passed chain is respected in the wallet strategy.

Detailed summary

  • Added ecosystem to the destructured args in the function signature.
  • Updated the connection logic to use client and chain from args.
  • Modified the clientFetch call to use client and ecosystem.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:01pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:01pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:01pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 9:01pm

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 72bec5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 27, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review January 27, 2025 20:53
@joaquim-verges joaquim-verges requested review from a team as code owners January 27, 2025 20:53
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 803 ms (-9.2% 🔽) 1.8 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 1.8 s (+22.39% 🔺) 4.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 194 ms (+124.28% 🔺) 306 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 68 ms (+468.02% 🔺) 78 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 258 ms (+142.31% 🔺) 640 ms

@joaquim-verges joaquim-verges merged commit 6c277ae into main Jan 27, 2025
26 of 32 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Respect_chain_param_in_in-app_wallet_connection branch January 27, 2025 20:57
@joaquim-verges joaquim-verges mentioned this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants