Skip to content

[SDK] fix: Respect chain param in in-app wallet connection #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

[SDK] fix: Respect chain param in in-app wallet connection #6068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-starfishes-sell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Respect passed in chain when connecting to inapp wallet with wallet strategy
6 changes: 3 additions & 3 deletions packages/thirdweb/src/wallets/in-app/core/authentication/siwe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ export async function siweAuthenticate(args: {
client: ThirdwebClient;
ecosystem?: Ecosystem;
}): Promise<AuthStoredTokenWithCookieReturnType> {
const { wallet, chain } = args;
const { wallet, chain, client, ecosystem } = args;
// only connect if the wallet doesn't already have an account
const account =
wallet.getAccount() || (await wallet.connect({ client: args.client }));
const clientFetch = getClientFetch(args.client, args.ecosystem);
wallet.getAccount() || (await wallet.connect({ client, chain }));
const clientFetch = getClientFetch(client, ecosystem);

const payload = await (async () => {
const path = getLoginUrl({
Expand Down
Loading