[TOOL-3260] SDK: Fix Pay Modal logging react-query error when opened #6104
Conversation
🦋 Changeset detectedLatest commit: 113e1a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
| if (!account || !wallet) return; | ||
| // Query data cannot be undefined, return null | ||
| if (!account || !wallet) { | ||
| return null; |
There was a problem hiding this comment.
should it just throw instead so it retries later?
also should we add !!account to enabled prop below?
size-limit report 📦
|
joaquim-verges
deleted the
01-30-_tool-3260_sdk_fix_pay_modal_logging_react-query_error_when_opened
branch
PR-Codex overview
This PR focuses on fixing the logging of a react-query error in the
thirdwebPay Modal when it is opened, ensuring that an error is thrown only when bothaccountandwalletare not available.Detailed summary
TransactionModalto throw an error ifaccountorwalletis missing.return nullstatement after the error throw.enabledproperty to check bothwalletandaccount.