Skip to content

[TOOL-3260] SDK: Fix Pay Modal logging react-query error when opened #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2025
Merged

[TOOL-3260] SDK: Fix Pay Modal logging react-query error when opened #6104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d5580
[TOOL-3260] SDK: Fix Pay Modal logging react-query error when opened
MananTank Jan 29, 2025
113e1a9
address gh comment
MananTank Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gentle-dancers-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix thirdweb Pay Modal logging react-query error when opened
7 changes: 6 additions & 1 deletion packages/thirdweb/src/react/web/ui/TransactionButton/TransactionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,19 @@ export function TransactionModal(props: ModalProps) {
useQuery({
queryKey: ["transaction-modal-event"],
queryFn: () => {
if (!account || !wallet) return;
// Query data cannot be undefined, return null
if (!account || !wallet) {
return null;
Copy link
Member

@joaquim-verges joaquim-verges Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it just throw instead so it retries later?

also should we add !!account to enabled prop below?

Copy link
Member Author

@MananTank MananTank Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

}
trackPayEvent({
client: props.client,
walletAddress: account.address,
walletType: wallet.id,
dstChainId: props.tx.chain.id,
event: "open_pay_transaction_modal",
});

return null;
},
enabled: !!wallet,
});
Expand Down
Loading