Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 12, 2025


PR-Codex overview

This PR focuses on enhancing the PayEmbed component by preventing editing of amounts when not in fund_wallet mode, and it introduces a disabled prop to relevant components for better control over user interactions.

Detailed summary

  • Added logic to disable amount editing in PayEmbed for non-fund_wallet modes.
  • Introduced a disabled prop in the SelectedTokenInfo component.
  • Updated the MainScreen to conditionally freeze amounts based on editing permissions.
  • Passed the disabled prop to the TokenSelectedLayout component.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:48am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:48am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:48am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:48am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 7:48am

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 322d2a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch
thirdweb-login Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review February 12, 2025 07:41
@joaquim-verges joaquim-verges requested review from a team as code owners February 12, 2025 07:41
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 12, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.21 KB (0%) 925 ms (0%) 670 ms (+88.72% 🔺) 1.6 s
thirdweb (cjs) 121.86 KB (0%) 2.5 s (0%) 1.2 s (+30.09% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 48 ms (+35.03% 🔺) 160 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 10 ms (-34.8% 🔽) 20 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 198 ms (+129.88% 🔺) 584 ms

@joaquim-verges joaquim-verges merged commit 6b286c7 into main Feb 12, 2025
31 of 35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Disable_amount_editing_for_non-wallet_funding_modes branch February 12, 2025 09:23
@joaquim-verges joaquim-verges mentioned this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants