Skip to content

[SDK] fix: Disable amount editing for non-wallet funding modes #6236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[SDK] fix: Disable amount editing for non-wallet funding modes #6236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-timers-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Dont allow editing amoutns for non fund_wallet modes in PayEmbed
19 changes: 16 additions & 3 deletions packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/BuyScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,11 @@ function BuyScreenContent(props: BuyScreenContentProps) {
screen.id === "buy-with-fiat") &&
payer && (
<TokenSelectedLayout
disabled={
("prefillBuy" in payOptions &&
payOptions.prefillBuy?.allowEdits?.amount === false) ||
payOptions.mode !== "fund_wallet"
}
title={props.title}
selectedChain={toChain}
selectedToken={toToken}
Expand Down Expand Up @@ -651,6 +656,7 @@ function SelectedTokenInfo(props: {
tokenAmount: string;
setTokenAmount: (amount: string) => void;
client: ThirdwebClient;
disabled?: boolean;
}) {
const getWidth = () => {
let chars = props.tokenAmount.replace(".", "").length;
Expand Down Expand Up @@ -680,7 +686,7 @@ function SelectedTokenInfo(props: {
type="text"
data-placeholder={props.tokenAmount === ""}
value={props.tokenAmount || "0"}
disabled={false} // TODO: add disabled freeze amount
disabled={props.disabled}
onClick={(e) => {
// put cursor at the end of the input
if (props.tokenAmount === "") {
Expand Down Expand Up @@ -865,8 +871,13 @@ function MainScreen(props: {
}}
freezeAmount={payOptions.prefillBuy?.allowEdits?.amount === false}
freezeChainAndToken={
payOptions.prefillBuy?.allowEdits?.chain === false &&
payOptions.prefillBuy?.allowEdits?.token === false
(payOptions.prefillBuy?.allowEdits?.chain === false &&
payOptions.prefillBuy?.allowEdits?.token === false) ||
(payOptions.buyWithCrypto !== false &&
payOptions.buyWithCrypto?.prefillSource?.allowEdits?.token ===
false &&
payOptions.buyWithCrypto?.prefillSource?.allowEdits?.chain ===
false)
}
token={toToken}
chain={toChain}
Expand Down Expand Up @@ -924,6 +935,7 @@ function TokenSelectedLayout(props: {
selectedChain: Chain;
client: ThirdwebClient;
onBack: () => void;
disabled?: boolean;
}) {
return (
<Container>
Expand All @@ -944,6 +956,7 @@ function TokenSelectedLayout(props: {
tokenAmount={props.tokenAmount}
setTokenAmount={props.setTokenAmount}
client={props.client}
disabled={props.disabled}
/>

<Spacer y="md" />
Expand Down
Loading