Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Feb 18, 2025

PR-Codex overview

This PR focuses on refactoring the handling of API keys and project settings within the application, consolidating logic, and improving type definitions for better clarity and maintainability.

Detailed summary

  • Removed getAPIKeys.ts.
  • Updated type definitions for TeamResponse and ProjectResponse.
  • Replaced notFound() with redirect() in various components for better navigation.
  • Changed LazyCreateAPIKeyDialog to LazyCreateProjectDialog.
  • Updated components to reflect new project and team structures.
  • Enhanced handling of project settings and API key updates.
  • Improved error handling and user feedback in forms.
  • Added support for new project service types in service-utils.

The following files were skipped due to too many changes: apps/dashboard/src/@3rdweb-sdk/react/hooks/useApi.ts, apps/dashboard/src/components/settings/ApiKeys/Create/index.tsx, apps/dashboard/src/app/team/[team_slug]/[project_slug]/settings/ProjectGeneralSettingsPage.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 18, 2025

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: 8610b46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login February 18, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 18, 2025 23:07 Inactive
@vercel
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 0:54am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 0:54am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 0:54am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 0:54am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 0:54am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 18, 2025 23:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 18, 2025 23:07 Inactive
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Feb 18, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review February 18, 2025 23:07
@MananTank MananTank requested review from a team as code owners February 18, 2025 23:07
@codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (d4a49b2) to head (8610b46).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6293   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files        1168     1168           
  Lines       64793    64793           
  Branches     5260     5260           
=======================================
  Hits        36824    36824           
  Misses      27242    27242           
  Partials      727      727           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d4a49b2
packages 55.04% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.3 KB (0%) 926 ms (0%) 2 s (-3.07% 🔽) 2.9 s
thirdweb (cjs) 121.89 KB (0%) 2.5 s (0%) 4.9 s (-10.33% 🔽) 7.3 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 249 ms (+66.14% 🔺) 361 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 111 ms (+48.8% 🔺) 121 ms
thirdweb/react (minimal + tree-shaking) 19.29 KB (0%) 386 ms (0%) 892 ms (+102.84% 🔺) 1.3 s

Copy link
Member Author

changeset added

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 19, 2025

Merge activity

<!-- start pr-codex -->

## PR-Codex overview
This PR focuses on refactoring the project and team management functionalities in the application, specifically updating the handling of API keys, project settings, and team responses, alongside improving redirection logic and type definitions.

### Detailed summary
- Removed `getAPIKeys.ts`.
- Updated types for `TeamResponse` and `ProjectResponse`.
- Changed redirection logic in various components to use the correct team/project slugs.
- Updated `ProjectGeneralSettingsPage` to use the new project structure.
- Refactored API key handling to support new project structure.
- Replaced instances of `LazyCreateAPIKeyDialog` with `LazyCreateProjectDialog`.
- Updated service utilities to include new project-related types.
- Improved error handling and user feedback in settings pages.

> The following files were skipped due to too many changes: `apps/dashboard/src/@3rdweb-sdk/react/hooks/useApi.ts`, `apps/dashboard/src/components/settings/ApiKeys/Create/index.tsx`, `apps/dashboard/src/app/team/[team_slug]/[project_slug]/settings/ProjectGeneralSettingsPage.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants