[SDK] fix: Update contract ABI caching strategy #6356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: cf2fa98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joaquim-verges
changed the title
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
joaquim-verges
changed the title
Contributor
size-limit report 📦
|
jnsdls
reviewed
Feb 27, 2025
joaquim-verges
force-pushed
the
_thirdweb_fix_Update_contract_ABI_caching_strategy
branch
from
4606540 to
c696f9c
Compare
joaquim-verges
force-pushed
the
_thirdweb_fix_Update_contract_ABI_caching_strategy
branch
from
c696f9c to
b39e658
Compare
joaquim-verges
force-pushed
the
_thirdweb_fix_Update_contract_ABI_caching_strategy
branch
2 times, most recently
from
ceedf52 to
a2b4ce7
Compare
jnsdls
approved these changes
Feb 27, 2025
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+48
to
+51
| return (await resolveAbiFromContractApi( | ||
| contract, | ||
| contractApiBaseUrl, | ||
| )) as abi; |
Contributor
There was a problem hiding this comment.
Network requests should be wrapped with timeout and proper error handling, and the AbortSignal should be passed to the fetch calls. The withCache utility should also handle request cancellation properly.
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
joaquim-verges
force-pushed
the
_thirdweb_fix_Update_contract_ABI_caching_strategy
branch
from
a2b4ce7 to
40784a2
Compare
joaquim-verges
force-pushed
the
_thirdweb_fix_Update_contract_ABI_caching_strategy
branch
from
40784a2 to
0c0e60f
Compare
joaquim-verges
force-pushed
the
_thirdweb_fix_Update_contract_ABI_caching_strategy
branch
from
0c0e60f to
cf2fa98
Compare
joaquim-verges
deleted the
_thirdweb_fix_Update_contract_ABI_caching_strategy
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the caching strategy for resolving contract ABIs in the
resolve-abi.tsfile and modifying the CI workflow to run on a different Ubuntu version.Detailed summary
runs-onparameter in.github/workflows/CI.ymlfromubuntu-latesttoubuntu-latest-8across multiple jobs.withCachefor caching in theresolveContractAbifunction inpackages/thirdweb/src/contract/actions/resolve-abi.ts.ABI_RESOLUTION_CACHEimplementation.