[SDK] feat: Add transfer success callback #6415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Playground
joaquim-verges
changed the title
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/wallets/smart/smart-wallet-integration-v07.test.ts
Show resolved
Hide resolved
Contributor
size-limit report 📦
|
joaquim-verges
force-pushed
the
_SDK_feat_Add_transfer_success_callback_and_ecosystem_partner_ID
branch
from
67b3cf6 to
d28bb8a
Compare
🦋 Changeset detectedLatest commit: d28bb8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6415 +/- ##
==========================================
- Coverage 54.72% 54.61% -0.12%
==========================================
Files 874 874
Lines 54621 54723 +102
Branches 3722 3711 -11
==========================================
- Hits 29894 29888 -6
- Misses 24633 24740 +107
- Partials 94 95 +1
|
joaquim-verges
deleted the
_SDK_feat_Add_transfer_success_callback_and_ecosystem_partner_ID
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the wallet functionality within the
thirdwebpackage, including new features for transaction handling and integration improvements, particularly around theonPurchaseSuccessevent and ecosystem wallet management.Detailed summary
waitForDeploymentoption inbundler.ts.onPurchaseSuccessfor wallet-to-wallet transfers.timeoutand setretryto0in wallet integration tests.tokenIdfrom1nto2nintransaction-button.tsx.getEcosystemtogetEcosystemWalletinecosystem.tsx.TransferConfirmationScreento propagateonPurchaseSuccessand handle transaction metadata.