-
Notifications
You must be signed in to change notification settings - Fork 621
[SDK] fix: Enforce requireApproval option for wallet connection #6505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Enforce requireApproval option for wallet connection #6505
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ea68e1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6505 +/- ##
==========================================
- Coverage 54.77% 54.76% -0.02%
==========================================
Files 875 875
Lines 54903 54883 -20
Branches 3739 3735 -4
==========================================
- Hits 30073 30055 -18
Misses 24735 24735
+ Partials 95 93 -2
🚀 New features to boost your workflow:
|

Fixes TOOL-3537
PR-Codex overview
This PR addresses an issue where the
requireApprovaloption was not being enforced during wallet connections in thethirdwebpackage, ensuring that users must approve the terms of service before proceeding.Detailed summary
requireApprovallogic in theWalletSelector.tsxfile.disabledattribute to theButtoncomponent, which is now conditionally disabled based onprops.meta.requireApprovalandapprovedTOS.WalletTypeRowButtonalso respects therequireApprovalcondition.