Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 20, 2025

Fixes TOOL-3537


PR-Codex overview

This PR addresses an issue where the requireApproval option was not being enforced during wallet connections in the thirdweb package, ensuring that users must approve the terms of service before proceeding.

Detailed summary

  • Updated the requireApproval logic in the WalletSelector.tsx file.
  • Added a disabled attribute to the Button component, which is now conditionally disabled based on props.meta.requireApproval and approvedTOS.
  • Ensured that the WalletTypeRowButton also respects the requireApproval condition.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:25am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:25am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:25am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:25am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 7:25am

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: ea68e1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 20, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Mar 20, 2025

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.92 KB (0%) 939 ms (0%) 152 ms (+141.92% 🔺) 1.1 s
thirdweb (cjs) 127.17 KB (0%) 2.6 s (0%) 214 ms (+37.78% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 73 ms (+1484.84% 🔺) 185 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 32 ms (+1663.1% 🔺) 42 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 74 ms (+578.37% 🔺) 461 ms

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.76%. Comparing base (d14a78c) to head (ea68e1e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../src/react/web/ui/ConnectWallet/WalletSelector.tsx 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6505      +/-   ##
==========================================
- Coverage   54.77%   54.76%   -0.02%     
==========================================
  Files         875      875              
  Lines       54903    54883      -20     
  Branches     3739     3735       -4     
==========================================
- Hits        30073    30055      -18     
  Misses      24735    24735              
+ Partials       95       93       -2     
Flag Coverage Δ
packages 54.76% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
.../src/react/web/ui/ConnectWallet/WalletSelector.tsx 9.87% <0.00%> (-0.04%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 7890145 into main Mar 20, 2025
34 of 35 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Enforce_requireApproval_option_for_wallet_connection branch March 20, 2025 08:59
@joaquim-verges joaquim-verges mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants