Skip to content

[SDK] fix: Enforce requireApproval option for wallet connection #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

[SDK] fix: Enforce requireApproval option for wallet connection #6505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/full-games-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix requireApproval option not enforced for wallet connection
2 changes: 2 additions & 0 deletions packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@
props.selectWallet(localWalletConfig);
}}
data-test="continue-as-guest-button"
disabled={props.meta.requireApproval && !approvedTOS}

Check warning on line 186 in packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx#L186 

Added line #L186 was not covered by tests
>
{props.connectLocale.continueAsGuest}
</Button>
Expand Down Expand Up @@ -227,6 +228,7 @@
<WalletTypeRowButton
client={props.client}
icon={OutlineWalletIcon}
disabled={props.meta.requireApproval && !approvedTOS}

Check warning on line 231 in packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/ConnectWallet/WalletSelector.tsx#L231 

Added line #L231 was not covered by tests
onClick={() => {
setIsWalletGroupExpanded(true);
}}
Expand Down