Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 3, 2025

PR-Codex overview

This PR focuses on enhancing the InAppWalletUsersChartCard component by adding a new BadgeContainer for a 120-day stat, updating date handling, and improving date formatting in the chart's axis.

Detailed summary

  • Added a BadgeContainer for displaying stats over 120 days in InAppWalletUsersChartCard.stories.tsx.
  • Updated the date generation logic in createInAppWalletStatsStub to use December instead of February.
  • Changed date formatting in InAppWalletUsersChartCardUI to use formatDate instead of format.
  • Modified the chart's X-axis tick formatter to format dates using formatDate.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 3, 2025

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 3, 2025 13:03 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 13:03 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 13:03 Inactive
@vercel
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2025 1:16pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 3, 2025 1:16pm
login ⬜️ Skipped (Inspect) Apr 3, 2025 1:16pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 3, 2025 1:16pm
wallet-ui ⬜️ Skipped (Inspect) Apr 3, 2025 1:16pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 13:03 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025

⚠️ No Changeset found

Latest commit: a7fd4e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 3, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review April 3, 2025 13:03
@MananTank MananTank requested review from a team as code owners April 3, 2025 13:03
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (61583cf) to head (a7fd4e5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6635   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         888      888           
  Lines       55753    55753           
  Branches     3816     3816           
=======================================
  Hits        30653    30653           
  Misses      25005    25005           
  Partials       95       95           
Flag Coverage Δ
packages 54.98% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnsdls approved this PR from Slack with Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.49 KB (0%) 950 ms (0%) 162 ms (+188.94% 🔺) 1.2 s
thirdweb (cjs) 129.89 KB (0%) 2.6 s (0%) 236 ms (+41.13% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 90 ms (+1430.3% 🔺) 202 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 32 ms (+2208.3% 🔺) 42 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 94 ms (+570.56% 🔺) 481 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 3, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-03-_tool-3946_dashboard_fix_in-app_wallet_users_chart_timestamp_incorrect_ordering branch from 13a4a26 to a7fd4e5 Compare April 3, 2025 13:10
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 3, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 3, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 3, 2025 13:10 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 3, 2025 13:10 Inactive
@graphite-app graphite-app bot merged commit a7fd4e5 into main Apr 3, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 04-03-_tool-3946_dashboard_fix_in-app_wallet_users_chart_timestamp_incorrect_ordering branch April 3, 2025 13:17
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 3, 2025 13:17 Inactive
@vercel vercel bot temporarily deployed to Production – login April 3, 2025 13:17 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 3, 2025 13:17 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants