Skip to content

[TOOL-3946] Dashboard: Fix in-app wallet users chart timestamp incorrect ordering #6635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

[TOOL-3946] Dashboard: Fix in-app wallet users chart timestamp incorrect ordering #6635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...dashboard/src/components/embedded-wallets/Analytics/InAppWalletUsersChartCard.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,15 @@ function Component() {
/>
</BadgeContainer>

<BadgeContainer label="120 days">
<InAppWalletUsersChartCardUI
inAppWalletStats={createInAppWalletStatsStub(120)}
isPending={false}
title={title}
description={description}
/>
</BadgeContainer>

<BadgeContainer label="10 days">
<InAppWalletUsersChartCardUI
inAppWalletStats={createInAppWalletStatsStub(10)}
Expand Down Expand Up @@ -117,7 +126,7 @@ function createInAppWalletStatsStub(days: number): InAppWalletStats[] {
while (d !== 0) {
const uniqueWallets = Math.floor(Math.random() * 100);
stubbedData.push({
date: new Date(2024, 1, d).toLocaleString(),
date: new Date(2024, 11, d).toLocaleString(),
uniqueWalletsConnected: uniqueWallets,
authenticationMethod: pickRandomAuthMethod(),
});
Expand Down
5 changes: 3 additions & 2 deletions apps/dashboard/src/components/embedded-wallets/Analytics/InAppWalletUsersChartCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { TypeScriptIcon } from "components/icons/brand-icons/TypeScriptIcon";
import { UnityIcon } from "components/icons/brand-icons/UnityIcon";
import { UnrealIcon } from "components/icons/brand-icons/UnrealIcon";
import { DocLink } from "components/shared/DocLink";
import { format } from "date-fns";
import { formatDate } from "date-fns";
import { useMemo } from "react";
import { Bar, BarChart, CartesianGrid, XAxis, YAxis } from "recharts";
import type { InAppWalletStats } from "types/analytics";
Expand Down Expand Up @@ -49,7 +49,7 @@ export function InAppWalletUsersChartCardUI(props: {
// if no data for current day - create new entry
if (!chartData && stat.uniqueWalletsConnected > 0) {
_chartDataMap.set(stat.date, {
time: format(new Date(stat.date), "MMM dd"),
time: stat.date,
[authenticationMethod || defaultLabel]: stat.uniqueWalletsConnected,
} as ChartData);
} else if (chartData) {
Expand Down Expand Up @@ -196,6 +196,7 @@ export function InAppWalletUsersChartCardUI(props: {
tickLine={false}
tickMargin={10}
axisLine={false}
tickFormatter={(value) => formatDate(new Date(value), "MMM d")}
/>

<YAxis
Expand Down
Loading