Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Apr 14, 2025

Closes: tool-4076
Screenshot 2025-04-13 at 17 24 15


PR-Codex overview

This PR updates the BuyFundsSection component to reflect a shift in functionality from buying funds to bridging funds. The title and text descriptions have been modified accordingly to enhance clarity about the bridging process.

Detailed summary

  • Changed the title from "Buy Funds" to "Bridge".
  • Updated the heading text from "Buy Funds on {sanitizedChainName} using Universal Bridge" to "Bridge Funds to {sanitizedChainName}".
  • Revised the paragraph to specify getting {props.chain.nativeCurrency.symbol} on {sanitizedChainName} with fiat or tokens from another chain.
  • Altered the button label from "Buy Funds on ${sanitizedChainName}" to "Bridge to ${sanitizedChainName}".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners April 14, 2025 00:23
@linear
Copy link

linear bot commented Apr 14, 2025

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

⚠️ No Changeset found

Latest commit: 1b2caec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 1:35am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 14, 2025 1:35am
login ⬜️ Skipped (Inspect) Apr 14, 2025 1:35am
thirdweb_playground ⬜️ Skipped (Inspect) Apr 14, 2025 1:35am
wallet-ui ⬜️ Skipped (Inspect) Apr 14, 2025 1:35am

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (e574114) to head (1b2caec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6714   +/-   ##
=======================================
  Coverage   55.01%   55.01%           
=======================================
  Files         889      889           
  Lines       55904    55904           
  Branches     3824     3824           
=======================================
  Hits        30758    30758           
  Misses      25051    25051           
  Partials       95       95           
Flag Coverage Δ
packages 55.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.67 KB (0%) 954 ms (0%) 252 ms (+176.97% 🔺) 1.3 s
thirdweb (cjs) 130.06 KB (0%) 2.7 s (0%) 370 ms (+42.91% 🔺) 3 s
thirdweb (minimal + tree-shaking) 5.62 KB (0%) 113 ms (0%) 120 ms (+1617.73% 🔺) 232 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 45 ms (+2039.14% 🔺) 55 ms
thirdweb/react (minimal + tree-shaking) 19.36 KB (0%) 388 ms (0%) 89 ms (+379.82% 🔺) 477 ms

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Apr 14, 2025
Copy link
Contributor Author

gregfromstl commented Apr 14, 2025

Merge activity

Closes: tool-4076
![Screenshot 2025-04-13 at 17 24 15](https://github.com/user-attachments/assets/1e6a3f04-cf0d-4dfa-9924-b5b611caaa7a)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `BuyFundsSection` component to reflect a shift in terminology from "Buy Funds" to "Bridge Funds," enhancing clarity regarding the functionality offered.

### Detailed summary
- Changed the `SectionTitle` from "Buy Funds" to "Bridge".
- Updated the heading text from "Buy Funds on {sanitizedChainName} using Universal Bridge" to "Bridge Funds to {sanitizedChainName}".
- Modified the paragraph text to clarify the process of obtaining the native currency.
- Altered the `PayModalButton` label from "Buy Funds on {sanitizedChainName}" to "Bridge to {sanitizedChainName}".

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the greg/tool-4076-improve-copy-on-chainlist-pages branch from 5a3140f to 1b2caec Compare April 14, 2025 01:28
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 14, 2025 01:28 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 14, 2025 01:28 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 14, 2025 01:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 14, 2025 01:28 Inactive
@graphite-app graphite-app bot merged commit 1b2caec into main Apr 14, 2025
32 checks passed
@graphite-app graphite-app bot deleted the greg/tool-4076-improve-copy-on-chainlist-pages branch April 14, 2025 01:36
@graphite-app graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Apr 14, 2025
@vercel vercel bot temporarily deployed to Production – docs-v2 April 14, 2025 01:36 Inactive
@vercel vercel bot temporarily deployed to Production – login April 14, 2025 01:36 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 14, 2025 01:36 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 14, 2025 01:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants