Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 16, 2025


PR-Codex overview

This PR focuses on removing the NebulaWaitlistPage and related functionality from the codebase, while also updating components to reflect these changes, such as simplifying props and removing references to the waitlist.

Detailed summary

  • Deleted files related to the NebulaWaitlistPage.
  • Removed the getTeamNebulaWaitList function and its usage.
  • Updated ProjectSidebarLayout to remove showNebula prop.
  • Adjusted ProjectLayout to eliminate waitlist logic.
  • Removed conditional rendering of NebulaWaitlistPage in the layout.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 9:24pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 16, 2025 9:24pm
login ⬜️ Skipped (Inspect) Apr 16, 2025 9:24pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 16, 2025 9:24pm
wallet-ui ⬜️ Skipped (Inspect) Apr 16, 2025 9:24pm

@linear
Copy link

linear bot commented Apr 16, 2025

NEB-172 Remove waitlist

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 16, 2025 13:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 16, 2025 13:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 16, 2025 13:32 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 16, 2025 13:32 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: b1060de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 16, 2025
Copy link
Member Author

MananTank commented Apr 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title [NEB-172]: Remove Nebula waitlist [NEB-172]: Remove Nebula waitlist - DO NOT MERGE Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (0aca563) to head (b1060de).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6745   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         895      895           
  Lines       56384    56384           
  Branches     3848     3848           
=======================================
  Hits        30899    30899           
  Misses      25390    25390           
  Partials       95       95           
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.42 KB (0%) 1.1 s (0%) 219 ms (+257.75% 🔺) 1.3 s
thirdweb (cjs) 136.84 KB (0%) 2.8 s (0%) 314 ms (+94.5% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.64 KB (0%) 113 ms (0%) 90 ms (+1074.37% 🔺) 202 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 46 ms (+1859.14% 🔺) 56 ms
thirdweb/react (minimal + tree-shaking) 19.4 KB (0%) 388 ms (0%) 100 ms (+754.01% 🔺) 488 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 16, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on removing components and related functionality for managing the Nebula waitlist in the application. It simplifies the codebase by eliminating unused imports and references to the waitlist, streamlining the `ProjectSidebarLayout`, and adjusting the layout logic.

### Detailed summary
- Deleted files related to the Nebula waitlist functionality.
- Removed `getTeamNebulaWaitList` function and its associated type.
- Updated `ProjectSidebarLayout` to eliminate the `showNebula` prop.
- Simplified `ProjectLayout` by removing waitlist checks and related logic.
- Adjusted `Page` component to remove references to `NebulaWaitListPage`.
- Cleaned up the `Layout` component by removing waitlist handling and related imports.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 16, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 16, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 16, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 16, 2025 21:16 Inactive
@graphite-app graphite-app bot merged commit b1060de into main Apr 16, 2025
23 checks passed
@graphite-app graphite-app bot deleted the neb-172 branch April 16, 2025 21:25
@vercel vercel bot temporarily deployed to Production – login April 16, 2025 21:25 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 16, 2025 21:25 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 16, 2025 21:25 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 16, 2025 21:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants