Skip to content

[NEB-173]: Hide testnets in nebula chain selector #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[NEB-173]: Hide testnets in nebula chain selector #6746

merged 1 commit into from
Apr 16, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Apr 16, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces a new feature to the MultiNetworkSelector component, allowing it to optionally hide testnet chains based on a new prop, hideTestnets. This enhances the user experience by filtering out testnets when desired.

Detailed summary

  • Added a new optional prop hideTestnets to the MultiNetworkSelector component.
  • Implemented logic to filter out testnet chains if hideTestnets is true.
  • Updated the dependency array in the useEffect hook to include props.hideTestnets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Apr 16, 2025

NEB-173 only show mainnets in nebula chain selector

@vercel
Copy link

vercel bot commented Apr 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 9:25pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 16, 2025 9:25pm
login ⬜️ Skipped (Inspect) Apr 16, 2025 9:25pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 16, 2025 9:25pm
wallet-ui ⬜️ Skipped (Inspect) Apr 16, 2025 9:25pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 April 16, 2025 13:36 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 16, 2025 13:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 16, 2025 13:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 16, 2025 13:36 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 16, 2025
@MananTank Graphite App
Copy link
Member Author

MananTank commented Apr 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank mentioned this pull request Apr 16, 2025
Merged
@MananTank MananTank changed the title [NEB-173]: Hide testnets in nebula chain selector [NEB-173]: Hide testnets in nebula chain selector - DO NOT MERGE Apr 16, 2025
@codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (b1060de) to head (95a6c38).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6746   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         895      895           
  Lines       56384    56384           
  Branches     3848     3848           
=======================================
  Hits        30899    30899           
  Misses      25390    25390           
  Partials       95       95
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.42 KB (0%) 1.1 s (0%) 210 ms (+147.4% 🔺) 1.3 s
thirdweb (cjs) 136.84 KB (0%) 2.8 s (0%) 313 ms (+36.82% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.64 KB (0%) 113 ms (0%) 65 ms (+995.27% 🔺) 178 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 86 ms (+4296.91% 🔺) 96 ms
thirdweb/react (minimal + tree-shaking) 19.4 KB (0%) 388 ms (0%) 79 ms (+327.02% 🔺) 467 ms

@MananTank MananTank mentioned this pull request Apr 16, 2025
Merged
@MananTank MananTank changed the title [NEB-173]: Hide testnets in nebula chain selector - DO NOT MERGE [NEB-173]: Hide testnets in nebula chain selector Apr 16, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 95a6c38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 7e32325

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank mentioned this pull request Apr 16, 2025
Merged
@MananTank MananTank marked this pull request as ready for review April 16, 2025 19:58
@MananTank MananTank requested review from a team as code owners April 16, 2025 19:58
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 16, 2025 •
edited
Loading

Merge activity

@MananTank
[NEB-173]: Hide testnets in nebula chain selector (#6746)
95a6c38 
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces the ability to hide test networks in the `MultiNetworkSelector` component and updates its props accordingly.

### Detailed summary
- Added `hideTestnets` prop to `MultiNetworkSelector` in `NetworkSelectors.tsx`.
- Implemented filtering of `sortedChains` to exclude test networks if `hideTestnets` is true.
- Updated dependency array in `useEffect` to include `props.hideTestnets`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – login April 16, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 16, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 16, 2025 21:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 16, 2025 21:16 Inactive
Base automatically changed from neb-172 to main April 16, 2025 21:25
@graphite-app graphite-app bot merged commit 95a6c38 into main Apr 16, 2025
21 checks passed
@graphite-app graphite-app bot deleted the neb-173 branch April 16, 2025 21:26
@vercel vercel bot temporarily deployed to Production – wallet-ui April 16, 2025 21:26 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 16, 2025 21:26 Inactive
@vercel vercel bot temporarily deployed to Production – login April 16, 2025 21:26 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 16, 2025 21:26 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb-www April 16, 2025 21:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @joaquim-verges