Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Apr 16, 2025

This PR adds a null check for the peak date in the RPC Usage page to handle cases where there are no requests in the last 24 hours. It displays "No Requests in last 24 hours" instead of attempting to format a non-existent date. Additionally, it destructures the averageRate directly from the API data to improve code readability when passing it to the RateGraph and CountGraph components.


PR-Codex overview

This PR enhances the RPCUsage component by incorporating averageRate from apiData.data. It modifies the display logic for peakRate.date and updates data references in the RateGraph and CountGraph components to utilize the new averageRate variable.

Detailed summary

  • Added averageRate to destructured apiData.data.
  • Updated the date display logic for peakRate.date to handle cases with no requests.
  • Changed the data prop in RateGraph from apiData.data.averageRate to averageRate.
  • Changed the data prop in CountGraph from apiData.data.averageRate to averageRate.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 4:49pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Apr 16, 2025 4:49pm
login ⬜️ Skipped (Inspect) Apr 16, 2025 4:49pm
thirdweb_playground ⬜️ Skipped (Inspect) Apr 16, 2025 4:49pm
wallet-ui ⬜️ Skipped (Inspect) Apr 16, 2025 4:49pm

@vercel vercel bot temporarily deployed to Preview – login April 16, 2025 16:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 16, 2025 16:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 16, 2025 16:34 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

⚠️ No Changeset found

Latest commit: 0aca563

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 16, 2025 16:34 Inactive
@jnsdls jnsdls marked this pull request as ready for review April 16, 2025 16:34
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Apr 16, 2025
@jnsdls jnsdls requested review from a team as code owners April 16, 2025 16:34
Copy link
Member Author

jnsdls commented Apr 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.80%. Comparing base (5463baa) to head (0aca563).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6748   +/-   ##
=======================================
  Coverage   54.80%   54.80%           
=======================================
  Files         895      895           
  Lines       56384    56384           
  Branches     3848     3848           
=======================================
  Hits        30899    30899           
  Misses      25390    25390           
  Partials       95       95           
Flag Coverage Δ
packages 54.80% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.42 KB (0%) 1.1 s (0%) 198 ms (+104.73% 🔺) 1.3 s
thirdweb (cjs) 136.84 KB (0%) 2.8 s (0%) 334 ms (+24.78% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.64 KB (0%) 113 ms (0%) 29 ms (+222.51% 🔺) 141 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 36 ms (+1122.3% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.4 KB (0%) 388 ms (0%) 80 ms (+231.98% 🔺) 468 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 16, 2025

Merge activity

This PR adds a null check for the peak date in the RPC Usage page to handle cases where there are no requests in the last 24 hours. It displays "No Requests in last 24 hours" instead of attempting to format a non-existent date. Additionally, it destructures the `averageRate` directly from the API data to improve code readability when passing it to the RateGraph and CountGraph components.
@graphite-app graphite-app bot force-pushed the Fix_RPC_usage_page_to_handle_missing_peak_date branch from 03d6d4e to 0aca563 Compare April 16, 2025 16:42
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 16, 2025 16:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 16, 2025 16:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 16, 2025 16:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 16, 2025 16:42 Inactive
@graphite-app graphite-app bot merged commit 0aca563 into main Apr 16, 2025
23 checks passed
@graphite-app graphite-app bot deleted the Fix_RPC_usage_page_to_handle_missing_peak_date branch April 16, 2025 16:50
@vercel vercel bot temporarily deployed to Production – thirdweb_playground April 16, 2025 16:50 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui April 16, 2025 16:50 Inactive
@vercel vercel bot temporarily deployed to Production – login April 16, 2025 16:50 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 April 16, 2025 16:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants