Skip to content

Fix RPC usage page to handle missing peak date #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Fix RPC usage page to handle missing peak date #6748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions apps/dashboard/src/app/team/[team_slug]/(team)/~/usage/rpc/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default async function RPCUsage(props: {
return <div>Error fetching data, please try again later</div>;
}

const { peakRate, totalCounts } = apiData.data;
const { peakRate, totalCounts, averageRate } = apiData.data;

// Calculate percentage of limit for the peak
const peakPercentage = (peakRate.peakRPS / currentRateLimit) * 100;
Expand Down Expand Up @@ -113,7 +113,9 @@ export default async function RPCUsage(props: {
</div>
<p className="mt-1 text-muted-foreground text-xs">
<ClockIcon className="mr-1 inline h-3 w-3" />
{format(new Date(peakRate.date), "MMM d, HH:mm")}
{peakRate.date
? format(new Date(peakRate.date), "MMM d, HH:mm")
: "No Requests in last 24 hours"}
</p>
</CardContent>
</Card>
Expand Down Expand Up @@ -196,13 +198,13 @@ export default async function RPCUsage(props: {
<RateGraph
peakPercentage={peakPercentage}
currentRateLimit={currentRateLimit}
data={apiData.data.averageRate}
data={averageRate}
/>

<CountGraph
peakPercentage={peakPercentage}
currentRateLimit={currentRateLimit}
data={apiData.data.averageRate}
data={averageRate}
/>
</div>
);
Expand Down
Loading