Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 24, 2025


PR-Codex overview

This PR focuses on improving the state management of the isLoggedIn status in the useSiweAuth hook by updating it only on successful login and logout actions.

Detailed summary

  • Changed the callback from onSettled to onSuccess for both login and logout actions in the useSiweAuth hook.
  • Ensured isLoggedIn state is updated only after successful authentication actions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 9:51pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 9:51pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 9:51pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 9:51pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 9:51pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025

🦋 Changeset detected

Latest commit: 20fa383

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review April 24, 2025 21:43
@joaquim-verges joaquim-verges requested review from a team as code owners April 24, 2025 21:43
"thirdweb": patch
---

Only update isLoggedIn state on successfull logins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the changeset file: successfull should be spelled successful (with one 'l').

Suggested change
Only update isLoggedIn state on successfull logins
+Only update isLoggedIn state on successful logins

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.16 KB (0%) 1.1 s (0%) 186 ms (+182.3% 🔺) 1.3 s
thirdweb (cjs) 143.77 KB (0%) 2.9 s (0%) 345 ms (+84.68% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 67 ms (+974.09% 🔺) 181 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 28 ms (+653.86% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 88 ms (+513.51% 🔺) 474 ms

@joaquim-verges joaquim-verges merged commit 31ce837 into main Apr 24, 2025
20 of 23 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Only_update_isLoggedIn_state_on_successful_logins branch April 24, 2025 21:50
@joaquim-verges joaquim-verges mentioned this pull request Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants