Skip to content

[SDK] Only update isLoggedIn state on successful logins #6846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

[SDK] Only update isLoggedIn state on successful logins #6846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-candies-cough.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Only update isLoggedIn state on successfull logins
Copy link
Contributor

@graphite-app graphite-app bot Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the changeset file: successfull should be spelled successful (with one 'l').

Suggested change
Only update isLoggedIn state on successfull logins
+Only update isLoggedIn state on successful logins

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

4 changes: 2 additions & 2 deletions packages/thirdweb/src/react/core/hooks/auth/useSiweAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export function useSiweAuth(

return await authOptions.doLogin(signedPayload);
},
onSettled: () => {
onSuccess: () => {
return queryClient.invalidateQueries({
queryKey: ["siwe_auth", "isLoggedIn"],
});
Expand All @@ -126,7 +126,7 @@ export function useSiweAuth(

return await authOptions.doLogout();
},
onSettled: () => {
onSuccess: () => {
return queryClient.invalidateQueries({
queryKey: ["siwe_auth", "isLoggedIn"],
});
Expand Down
Loading