Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 12, 2025


PR-Codex overview

This PR focuses on enhancing the ImageUploadButton component to allow for more specific file type acceptance by adding an accept prop, which is used in the file input element.

Detailed summary

  • In ChatBar.tsx, added accept="image/jpeg,image/png,image/webp" to the file input.
  • In image-upload-button.tsx, added accept: string; to the ImageUploadProps interface.
  • Updated the accept attribute of the file input to use props.accept instead of a hardcoded value.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented May 12, 2025

@vercel
Copy link

vercel bot commented May 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2025 8:34pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 12, 2025 8:34pm
login ⬜️ Skipped (Inspect) May 12, 2025 8:34pm
thirdweb_playground ⬜️ Skipped (Inspect) May 12, 2025 8:34pm
wallet-ui ⬜️ Skipped (Inspect) May 12, 2025 8:34pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 12, 2025 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 18:09 Inactive
Copy link
Member Author

MananTank commented May 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 12, 2025
@MananTank MananTank marked this pull request as ready for review May 12, 2025 18:10
@MananTank MananTank requested review from a team as code owners May 12, 2025 18:10
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.71%. Comparing base (a3a4bf4) to head (f4ac3c2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7019   +/-   ##
=======================================
  Coverage   54.71%   54.71%           
=======================================
  Files         904      904           
  Lines       57991    57991           
  Branches     4004     4004           
=======================================
  Hits        31731    31731           
  Misses      26155    26155           
  Partials      105      105           
Flag Coverage Δ
packages 54.71% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.21 KB (0%) 1.1 s (0%) 265 ms (+142.05% 🔺) 1.4 s
thirdweb (cjs) 193.92 KB (0%) 3.9 s (0%) 445 ms (+13.7% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 61 ms (+416.29% 🔺) 174 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 39 ms (+804.03% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 57 ms (+209.35% 🔺) 448 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented May 12, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ImageUploadButton` component by allowing it to accept specific image file types and updating the `ChatBar` component to utilize this feature.

### Detailed summary
- In `ChatBar.tsx`, added `accept` attribute with value `"image/jpeg,image/png,image/webp"` to the file input.
- In `image-upload-button.tsx`, changed `accept` property from a static value `"image/*"` to a dynamic value using `props.accept`.
- Updated `ImageUploadButton` to include `accept` in its props definition.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2025

⚠️ No Changeset found

Latest commit: f4ac3c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 12, 2025 20:27 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 12, 2025 20:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 12, 2025 20:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 12, 2025 20:27 Inactive
@graphite-app graphite-app bot merged commit f4ac3c2 into main May 12, 2025
23 checks passed
@graphite-app graphite-app bot deleted the neb-245 branch May 12, 2025 20:34
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 12, 2025 20:35 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 May 12, 2025 20:35 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 12, 2025 20:35 Inactive
@vercel vercel bot temporarily deployed to Production – login May 12, 2025 20:35 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants