[NEB-239] Fix chain search not working properly for chain name starting with number #7023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7023 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 904 904
Lines 57991 57991
Branches 4004 4004
=======================================
Hits 31731 31731
Misses 26155 26155
Partials 105 105
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
This was referenced May 12, 2025
joaquim-verges
approved these changes
May 12, 2025
Contributor
Merge activity
|
MananTank
force-pushed
the
graphite-base/7023
branch
from
4d79d33 to
98d05d6
Compare
…ng with number (#7023) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the code by replacing `Number.parseInt` with `Number` for checking if a value is an integer across multiple files, enhancing readability and consistency. ### Detailed summary - In `TokenSelector.tsx`, changed `Number.parseInt(searchValue)` to `Number(searchValue)`. - In `single-network-selector.tsx`, modified the same integer check. - In `ConfigureCustomChain.tsx`, updated integer check for `chainSlug`. - In `NetworkSelectors.tsx`, replaced the integer check similarly. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the type handling of
searchValueandchainSlugby removing the unnecessary use ofNumber.parseIntand directly usingNumberto check if the values are integers.Detailed summary
TokenSelector.tsx, changedNumber.parseInt(searchValue)toNumber(searchValue)for integer check.single-network-selector.tsx, updated the same integer check fromNumber.parseInttoNumber.ConfigureCustomChain.tsx, modified the integer check forchainSlugsimilarly.NetworkSelectors.tsx, replacedNumber.parseInt(searchValue)withNumber(searchValue)for consistency.