Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented May 15, 2025


PR-Codex overview

This PR focuses on enhancing the TransactionsSection component by modifying the transaction fetch parameters and updating the ChainIconClient component's styling.

Detailed summary

  • Updated className of ChainIconClient to include rounded-full border.
  • Increased transaction limit from 10 to 20 in the URL search parameters.
  • Added a filter for transactions from the last three months using filter_block_timestamp_gte.
  • Changed the type of data in the response from WalletTransaction[] to WalletTransaction[]?, allowing for optional data.
  • Ensured the return value defaults to an empty array if data is undefined.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 5:20pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 15, 2025 5:20pm
login ⬜️ Skipped (Inspect) May 15, 2025 5:20pm
thirdweb_playground ⬜️ Skipped (Inspect) May 15, 2025 5:20pm
wallet-ui ⬜️ Skipped (Inspect) May 15, 2025 5:20pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 May 15, 2025 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 15, 2025 11:07 Inactive
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2025

⚠️ No Changeset found

Latest commit: c6b4d15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 15, 2025 11:07 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 15, 2025 11:07 Inactive
@MananTank MananTank marked this pull request as ready for review May 15, 2025 11:07
@MananTank MananTank requested review from a team as code owners May 15, 2025 11:07
Copy link
Member Author

MananTank commented May 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 15, 2025
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.50%. Comparing base (0eff648) to head (bfe1daa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7055   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         909      909           
  Lines       58402    58402           
  Branches     4070     4070           
=======================================
  Hits        32415    32415           
  Misses      25882    25882           
  Partials      105      105           
Flag Coverage Δ
packages 55.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.18 KB (0%) 1.1 s (0%) 219 ms (+109.46% 🔺) 1.4 s
thirdweb (cjs) 193.71 KB (0%) 3.9 s (0%) 457 ms (+9.67% 🔺) 4.4 s
thirdweb (minimal + tree-shaking) 5.68 KB (0%) 114 ms (0%) 60 ms (+622.53% 🔺) 173 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 19 ms (+543.51% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.53 KB (0%) 391 ms (0%) 72 ms (+357.06% 🔺) 462 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented May 15, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `TransactionsSection` component in the dashboard by modifying the transaction fetch limit and adding a filter for recent transactions.

### Detailed summary
- Updated `className` of `ChainIconClient` to include `rounded-full border`.
- Increased transaction limit from `10` to `20` in the URL query parameters.
- Added a filter for transactions from the last three months using `filter_block_timestamp_gte`.
- Changed the type of `json.data` from `WalletTransaction[]` to `WalletTransaction[]?`, allowing for undefined.
- Implemented a fallback to return an empty array if `json.data` is undefined.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot force-pushed the 05-15-nebula_recent_activity_improvements_in_sidebar branch from bfe1daa to c6b4d15 Compare May 15, 2025 17:12
@jnsdls jnsdls merged commit 2057546 into main May 15, 2025
10 checks passed
@jnsdls jnsdls deleted the 05-15-nebula_recent_activity_improvements_in_sidebar branch May 15, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants