[NEB-248] Show native token balances in assets, show popular tokens on top #7056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
apps/dashboard/src/app/nebula-app/(app)/components/AssetsSection/AssetsSection.tsx
Show resolved
Hide resolved
apps/dashboard/src/app/nebula-app/(app)/components/AssetsSection/AssetsSection.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7056 +/- ##
=======================================
Coverage 55.50% 55.50%
=======================================
Files 909 909
Lines 58402 58402
Branches 4070 4070
=======================================
Hits 32415 32415
Misses 25882 25882
Partials 105 105
🚀 New features to boost your workflow:
|
Contributor
size-limit report 📦
|
apps/dashboard/src/app/nebula-app/(app)/components/AssetsSection/AssetsSection.tsx
Outdated
Show resolved
Hide resolved
jnsdls
approved these changes
May 15, 2025
apps/dashboard/src/app/nebula-app/(app)/components/AssetsSection/AssetsSection.tsx
Show resolved
Hide resolved
apps/dashboard/src/app/nebula-app/(app)/components/AssetsSection/AssetsSection.tsx
Show resolved
Hide resolved
Contributor
Merge activity
|
graphite-app
bot
changed the base branch from
05-15-nebula_recent_activity_improvements_in_sidebar
to
graphite-base/7056
MananTank
force-pushed
the
graphite-base/7056
branch
from
bfe1daa to
c6b4d15
Compare
MananTank
changed the base branch from
graphite-base/7056
to
05-15-nebula_recent_activity_improvements_in_sidebar
Base automatically changed from
05-15-nebula_recent_activity_improvements_in_sidebar
to
main
May 15, 2025 20:52
…n top (#7056) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR enhances the `AssetsSection` component by integrating wallet balance retrieval, modifying how assets are displayed, and implementing new logic for sorting tokens. It also introduces a new constant for native tokens and adjusts rendering based on whether an asset is native. ### Detailed summary - Added `NATIVE_TOKEN_ADDRESS` and `getWalletBalance` import from `thirdweb`. - Updated `key` for `AssetItem` to include `chain_id`. - Introduced `isNativeToken` to conditionally render the `ChainIconClient`. - Modified the `href` for `Link` based on whether the asset is a native token. - Added a new set `tokensToShowOnTop` for sorting specific tokens. - Implemented `nativeBalances` query to fetch wallet balances for various chains. - Combined `nativeBalances` and `assetsQuery` data for rendering in `AssetsSectionUI`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances the
AssetsSectioncomponent by incorporating wallet balance retrieval, improving asset sorting, and adjusting the rendering logic for native tokens. It also refines the key generation for asset items and updates the UI accordingly.Detailed summary
NATIVE_TOKEN_ADDRESSandgetWalletBalanceimports fromthirdweb.chain_id.ChainIconClientbased on token type.