Skip to content

chore: moved solidstart dep as dev dep#4

Closed
thomasbuilds wants to merge 1 commit intomainfrom
chore
Closed

chore: moved solidstart dep as dev dep#4
thomasbuilds wants to merge 1 commit intomainfrom
chore

Conversation

@thomasbuilds
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings November 15, 2025 12:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR attempts to move @solidjs/start from peerDependencies to devDependencies and includes a minor version bump for @types/node. However, this change is problematic because the package imports the APIEvent type from @solidjs/start/server, which requires @solidjs/start to be available to package consumers for proper TypeScript compilation.

  • Moved @solidjs/start from peerDependencies to devDependencies (incorrect)
  • Updated @types/node from ^24.10.0 to ^24.10.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +33 to 37
"@solidjs/start": "^1.2.0",
"@types/node": "^24.10.1",
"prettier": "^3.6.2"
},
"peerDependencies": {
Copy link

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving @solidjs/start from peerDependencies to devDependencies is incorrect. The package imports APIEvent type from @solidjs/start/server in src/index.ts (line 2), which means consumers of this package need @solidjs/start to be available for proper TypeScript type checking and compilation.

@solidjs/start should remain in peerDependencies to indicate that users must have it installed in their project. Moving it to devDependencies means it will only be available during development of this package itself, not for consumers.

Suggested change
"@solidjs/start": "^1.2.0",
"@types/node": "^24.10.1",
"prettier": "^3.6.2"
},
"peerDependencies": {
"@types/node": "^24.10.1",
"prettier": "^3.6.2"
},
"peerDependencies": {
"@solidjs/start": "^1.2.0",

Copilot uses AI. Check for mistakes.
@thomasbuilds thomasbuilds deleted the chore branch November 15, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant