Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to move @solidjs/start from peerDependencies to devDependencies and includes a minor version bump for @types/node. However, this change is problematic because the package imports the APIEvent type from @solidjs/start/server, which requires @solidjs/start to be available to package consumers for proper TypeScript compilation.
- Moved
@solidjs/startfrompeerDependenciestodevDependencies(incorrect) - Updated
@types/nodefrom^24.10.0to^24.10.1
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@solidjs/start": "^1.2.0", | ||
| "@types/node": "^24.10.1", | ||
| "prettier": "^3.6.2" | ||
| }, | ||
| "peerDependencies": { |
There was a problem hiding this comment.
Moving @solidjs/start from peerDependencies to devDependencies is incorrect. The package imports APIEvent type from @solidjs/start/server in src/index.ts (line 2), which means consumers of this package need @solidjs/start to be available for proper TypeScript type checking and compilation.
@solidjs/start should remain in peerDependencies to indicate that users must have it installed in their project. Moving it to devDependencies means it will only be available during development of this package itself, not for consumers.
| "@solidjs/start": "^1.2.0", | |
| "@types/node": "^24.10.1", | |
| "prettier": "^3.6.2" | |
| }, | |
| "peerDependencies": { | |
| "@types/node": "^24.10.1", | |
| "prettier": "^3.6.2" | |
| }, | |
| "peerDependencies": { | |
| "@solidjs/start": "^1.2.0", |
No description provided.