Skip to content

chore: moved solidstart dep as dev dep #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thomasbuilds wants to merge 1 commit into from
Closed

chore: moved solidstart dep as dev dep #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@
"format": "prettier --write . --trailing-comma none"
},
"devDependencies": {
"@types/node": "^24.10.0",
"@solidjs/start": "^1.2.0",
"@types/node": "^24.10.1",
"prettier": "^3.6.2"
},
"peerDependencies": {
Comment on lines +33 to 37
Copy link

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving @solidjs/start from peerDependencies to devDependencies is incorrect. The package imports APIEvent type from @solidjs/start/server in src/index.ts (line 2), which means consumers of this package need @solidjs/start to be available for proper TypeScript type checking and compilation.

@solidjs/start should remain in peerDependencies to indicate that users must have it installed in their project. Moving it to devDependencies means it will only be available during development of this package itself, not for consumers.

Suggested change
"@solidjs/start": "^1.2.0",
"@types/node": "^24.10.1",
"prettier": "^3.6.2"
},
"peerDependencies": {
"@types/node": "^24.10.1",
"prettier": "^3.6.2"
},
"peerDependencies": {
"@solidjs/start": "^1.2.0",

Copilot uses AI. Check for mistakes.
"@solidjs/router": "^0.15.4",
"@solidjs/start": "^1.2.0"
"@solidjs/router": "^0.15.4"
},
"engines": {
"node": ">=22"
Expand Down
Loading
Loading