FactoryBot::DefinitionProxy: remove definition attr_reader#1752
Merged
neilvcarvalho merged 2 commits intothoughtbot:mainfrom Jun 3, 2025
Merged
Conversation
:definition was added as an attr_reader but raises an exception when a model with an attribute called :definition is set via :method_missing. Renaming to :root_definition solves this issue.
Contributor
Author
|
Hi @neilvcarvalho, this is a simpler solution & one that avoids any potential attribute naming conflict. 😀 |
Member
|
Thanks @CodeMeister! |
neilvcarvalho
changed the title
definition attr_reader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1751
A new
attr_reader :definitionwas added to FactoryBot::DefinitionProxy.When trying to set an instance attribute named
:definitionusing:method_missing, it's targeting the proxy:definitionrather than creating an attribute, leading to an exceptionI've removed the
:instancemethod and changed all references to@instance🤔